diff mbox series

[-next] hid/hid-sensor-custom: convert comma to semicolon

Message ID 20201214133212.3569-1-zhengyongjun3@huawei.com (mailing list archive)
State New
Delegated to: Jiri Kosina
Headers show
Series [-next] hid/hid-sensor-custom: convert comma to semicolon | expand

Commit Message

Zheng Yongjun Dec. 14, 2020, 1:32 p.m. UTC
Replace a comma between expression statements by a semicolon.

Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
 drivers/hid/hid-sensor-custom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Srinivas Pandruvada Dec. 14, 2020, 2:13 p.m. UTC | #1
On Mon, 2020-12-14 at 21:32 +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

> ---
>  drivers/hid/hid-sensor-custom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-
> sensor-custom.c
> index 4d25577a8573..6c47a2e7623d 100644
> --- a/drivers/hid/hid-sensor-custom.c
> +++ b/drivers/hid/hid-sensor-custom.c
> @@ -728,7 +728,7 @@ static int hid_sensor_custom_dev_if_add(struct
> hid_sensor_custom *sensor_inst)
>  
>         sensor_inst->custom_dev.minor = MISC_DYNAMIC_MINOR;
>         sensor_inst->custom_dev.name = dev_name(&sensor_inst->pdev-
> >dev);
> -       sensor_inst->custom_dev.fops = &hid_sensor_custom_fops,
> +       sensor_inst->custom_dev.fops = &hid_sensor_custom_fops;
>         ret = misc_register(&sensor_inst->custom_dev);
>         if (ret) {
>                 kfifo_free(&sensor_inst->data_fifo);
Jonathan Cameron Dec. 29, 2020, 6:18 p.m. UTC | #2
On Mon, 14 Dec 2020 06:13:58 -0800
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> wrote:

> On Mon, 2020-12-14 at 21:32 +0800, Zheng Yongjun wrote:
> > Replace a comma between expression statements by a semicolon.
> > 
> > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>  
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to see if they can break it.

Thanks,

Jonathan

> 
> > ---
> >  drivers/hid/hid-sensor-custom.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-
> > sensor-custom.c
> > index 4d25577a8573..6c47a2e7623d 100644
> > --- a/drivers/hid/hid-sensor-custom.c
> > +++ b/drivers/hid/hid-sensor-custom.c
> > @@ -728,7 +728,7 @@ static int hid_sensor_custom_dev_if_add(struct
> > hid_sensor_custom *sensor_inst)
> >  
> >         sensor_inst->custom_dev.minor = MISC_DYNAMIC_MINOR;
> >         sensor_inst->custom_dev.name = dev_name(&sensor_inst->pdev-  
> > >dev);  
> > -       sensor_inst->custom_dev.fops = &hid_sensor_custom_fops,
> > +       sensor_inst->custom_dev.fops = &hid_sensor_custom_fops;
> >         ret = misc_register(&sensor_inst->custom_dev);
> >         if (ret) {
> >                 kfifo_free(&sensor_inst->data_fifo);  
> 
>
Jonathan Cameron Jan. 20, 2021, 8:49 p.m. UTC | #3
On Tue, 29 Dec 2020 18:18:41 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Mon, 14 Dec 2020 06:13:58 -0800
> Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> wrote:
> 
> > On Mon, 2020-12-14 at 21:32 +0800, Zheng Yongjun wrote:  
> > > Replace a comma between expression statements by a semicolon.
> > > 
> > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>    
> > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>  
> Applied to the togreg branch of iio.git and pushed out as testing for
> the autobuilders to see if they can break it.
Hi Jiri,

Just realised this is in HID rather than IIO. I hope you don't mind as
it's now deep in a tree I'd rather not rebase.

Sorry about that.

Jonathan

> 
> Thanks,
> 
> Jonathan
> 
> >   
> > > ---
> > >  drivers/hid/hid-sensor-custom.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-
> > > sensor-custom.c
> > > index 4d25577a8573..6c47a2e7623d 100644
> > > --- a/drivers/hid/hid-sensor-custom.c
> > > +++ b/drivers/hid/hid-sensor-custom.c
> > > @@ -728,7 +728,7 @@ static int hid_sensor_custom_dev_if_add(struct
> > > hid_sensor_custom *sensor_inst)
> > >  
> > >         sensor_inst->custom_dev.minor = MISC_DYNAMIC_MINOR;
> > >         sensor_inst->custom_dev.name = dev_name(&sensor_inst->pdev-    
> > > >dev);    
> > > -       sensor_inst->custom_dev.fops = &hid_sensor_custom_fops,
> > > +       sensor_inst->custom_dev.fops = &hid_sensor_custom_fops;
> > >         ret = misc_register(&sensor_inst->custom_dev);
> > >         if (ret) {
> > >                 kfifo_free(&sensor_inst->data_fifo);    
> > 
> >   
>
Jonathan Cameron Jan. 22, 2021, 8:54 a.m. UTC | #4
On Wed, 20 Jan 2021 20:49:57 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Tue, 29 Dec 2020 18:18:41 +0000
> Jonathan Cameron <jic23@kernel.org> wrote:
> 
> > On Mon, 14 Dec 2020 06:13:58 -0800
> > Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> wrote:
> >   
> > > On Mon, 2020-12-14 at 21:32 +0800, Zheng Yongjun wrote:    
> > > > Replace a comma between expression statements by a semicolon.
> > > > 
> > > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>      
> > > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>    
> > Applied to the togreg branch of iio.git and pushed out as testing for
> > the autobuilders to see if they can break it.  
> Hi Jiri,
> 
> Just realised this is in HID rather than IIO. I hope you don't mind as
> it's now deep in a tree I'd rather not rebase.

On basis it wasn't actually that bad, (only one merge after it) I did
the rebase and dropped this patch.  Jiri, guess you probably
want to pick this up through HID.

Thanks,

Jonathan

> 
> Sorry about that.
> 
> Jonathan
> 
> > 
> > Thanks,
> > 
> > Jonathan
> >   
> > >     
> > > > ---
> > > >  drivers/hid/hid-sensor-custom.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-
> > > > sensor-custom.c
> > > > index 4d25577a8573..6c47a2e7623d 100644
> > > > --- a/drivers/hid/hid-sensor-custom.c
> > > > +++ b/drivers/hid/hid-sensor-custom.c
> > > > @@ -728,7 +728,7 @@ static int hid_sensor_custom_dev_if_add(struct
> > > > hid_sensor_custom *sensor_inst)
> > > >  
> > > >         sensor_inst->custom_dev.minor = MISC_DYNAMIC_MINOR;
> > > >         sensor_inst->custom_dev.name = dev_name(&sensor_inst->pdev-      
> > > > >dev);      
> > > > -       sensor_inst->custom_dev.fops = &hid_sensor_custom_fops,
> > > > +       sensor_inst->custom_dev.fops = &hid_sensor_custom_fops;
> > > >         ret = misc_register(&sensor_inst->custom_dev);
> > > >         if (ret) {
> > > >                 kfifo_free(&sensor_inst->data_fifo);      
> > > 
> > >     
> >   
>
Jiri Kosina Jan. 22, 2021, 10:58 a.m. UTC | #5
On Wed, 20 Jan 2021, Jonathan Cameron wrote:

> > > > Replace a comma between expression statements by a semicolon.
> > > > 
> > > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>    
> > > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>  
> > Applied to the togreg branch of iio.git and pushed out as testing for
> > the autobuilders to see if they can break it.
> Hi Jiri,
> 
> Just realised this is in HID rather than IIO. I hope you don't mind as
> it's now deep in a tree I'd rather not rebase.
> 
> Sorry about that.

No worries, feel free to keep it in your tree.

Thanks,
diff mbox series

Patch

diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-sensor-custom.c
index 4d25577a8573..6c47a2e7623d 100644
--- a/drivers/hid/hid-sensor-custom.c
+++ b/drivers/hid/hid-sensor-custom.c
@@ -728,7 +728,7 @@  static int hid_sensor_custom_dev_if_add(struct hid_sensor_custom *sensor_inst)
 
 	sensor_inst->custom_dev.minor = MISC_DYNAMIC_MINOR;
 	sensor_inst->custom_dev.name = dev_name(&sensor_inst->pdev->dev);
-	sensor_inst->custom_dev.fops = &hid_sensor_custom_fops,
+	sensor_inst->custom_dev.fops = &hid_sensor_custom_fops;
 	ret = misc_register(&sensor_inst->custom_dev);
 	if (ret) {
 		kfifo_free(&sensor_inst->data_fifo);