| Message ID | 20210217190718.11035-2-ronald@innovation.ch (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e64123949e6c9581c97fc14594f1cf34bf1d87a8 |
| Headers | show |
| Series | [1/3] Input: applespi: Don't wait for responses to commands indefinitely. | expand |
On Wed, Feb 17, 2021 at 11:07:17AM -0800, Ronald Tschalär wrote: > For some reason, when the system is under heavy CPU load, the read > following the write sometimes occurs unusually quickly, resulting in > the read data not being quite ready and hence a bad packet getting read. > Adding another delay after reading the status message appears to fix > this. > > Signed-off-by: Ronald Tschalär <ronald@innovation.ch> Applied, thank you.
diff --git a/drivers/input/keyboard/applespi.c b/drivers/input/keyboard/applespi.c index 8494bf610fd70..f0a0067c48ff6 100644 --- a/drivers/input/keyboard/applespi.c +++ b/drivers/input/keyboard/applespi.c @@ -749,6 +749,8 @@ static void applespi_async_write_complete(void *context) applespi->tx_status, APPLESPI_STATUS_SIZE); + udelay(SPI_RW_CHG_DELAY_US); + if (!applespi_check_write_status(applespi, applespi->wr_m.status)) { /* * If we got an error, we presumably won't get the expected
For some reason, when the system is under heavy CPU load, the read following the write sometimes occurs unusually quickly, resulting in the read data not being quite ready and hence a bad packet getting read. Adding another delay after reading the status message appears to fix this. Signed-off-by: Ronald Tschalär <ronald@innovation.ch> --- drivers/input/keyboard/applespi.c | 2 ++ 1 file changed, 2 insertions(+)