diff mbox series

input: misc: max8997: Simplify open coding of a division using up to 64 divisions

Message ID 20210316211822.49830-1-uwe@kleine-koenig.org (mailing list archive)
State Superseded
Headers show
Series input: misc: max8997: Simplify open coding of a division using up to 64 divisions | expand

Commit Message

Uwe Kleine-König March 16, 2021, 9:18 p.m. UTC
The for loop is just a complicate way to express a division. Replace it
by the actual division which is both simpler to understand for a human
and more efficient for a CPU to calculate.

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
---
 drivers/input/misc/max8997_haptic.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
diff mbox series

Patch

diff --git a/drivers/input/misc/max8997_haptic.c b/drivers/input/misc/max8997_haptic.c
index c86966ea0f16..6baca94ed424 100644
--- a/drivers/input/misc/max8997_haptic.c
+++ b/drivers/input/misc/max8997_haptic.c
@@ -68,12 +68,8 @@  static int max8997_haptic_set_duty_cycle(struct max8997_haptic *chip)
 		int i;
 		u8 duty_index = 0;
 
-		for (i = 0; i <= 64; i++) {
-			if (chip->level <= i * 100 / 64) {
-				duty_index = i;
-				break;
-			}
-		}
+		duty_index = DIV_ROUNDUP(chip->level * 64, 100);
+
 		switch (chip->internal_mode_pattern) {
 		case 0:
 			max8997_write_reg(chip->client,