diff mbox series

[06/25] HID: usbhid: Repair a formatting issue in a struct description

Message ID 20210326143458.508959-8-lee.jones@linaro.org (mailing list archive)
State New
Delegated to: Jiri Kosina
Headers show
Series Rid W=1 warnings from HID | expand

Commit Message

Lee Jones March 26, 2021, 2:34 p.m. UTC
Fixes the following W=1 kernel build warning(s):

 drivers/hid/usbhid/usbkbd.c:66: warning: bad line:                 should be on

Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: message to <vojtech@ucw.cz>
Cc: linux-usb@vger.kernel.org
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/hid/usbhid/usbkbd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Benjamin Tissoires April 7, 2021, 4:56 p.m. UTC | #1
On Fri, Mar 26, 2021 at 3:35 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/hid/usbhid/usbkbd.c:66: warning: bad line:                 should be on
>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: message to <vojtech@ucw.cz>
> Cc: linux-usb@vger.kernel.org
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/hid/usbhid/usbkbd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c
> index d5b7a696a68c5..d0c640be8a885 100644
> --- a/drivers/hid/usbhid/usbkbd.c
> +++ b/drivers/hid/usbhid/usbkbd.c
> @@ -63,7 +63,7 @@ static const unsigned char usb_kbd_keycode[256] = {
>   *             new key is pressed or a key that was pressed is released.
>   * @led:       URB for sending LEDs (e.g. numlock, ...)
>   * @newleds:   data that will be sent with the @led URB representing which LEDs
> -               should be on
> + *             should be on

nitpick: checkpatch complains about spaces before tabs here.

I amended locally and will push the fixed version.

Cheers,
Benjamin

>   * @name:      Name of the keyboard. @dev's name field points to this buffer
>   * @phys:      Physical path of the keyboard. @dev's phys field points to this
>   *             buffer
> --
> 2.27.0
>
Lee Jones April 8, 2021, 7:05 a.m. UTC | #2
On Wed, 07 Apr 2021, Benjamin Tissoires wrote:

> On Fri, Mar 26, 2021 at 3:35 PM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> >  drivers/hid/usbhid/usbkbd.c:66: warning: bad line:                 should be on
> >
> > Cc: Jiri Kosina <jikos@kernel.org>
> > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > Cc: message to <vojtech@ucw.cz>
> > Cc: linux-usb@vger.kernel.org
> > Cc: linux-input@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >  drivers/hid/usbhid/usbkbd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c
> > index d5b7a696a68c5..d0c640be8a885 100644
> > --- a/drivers/hid/usbhid/usbkbd.c
> > +++ b/drivers/hid/usbhid/usbkbd.c
> > @@ -63,7 +63,7 @@ static const unsigned char usb_kbd_keycode[256] = {
> >   *             new key is pressed or a key that was pressed is released.
> >   * @led:       URB for sending LEDs (e.g. numlock, ...)
> >   * @newleds:   data that will be sent with the @led URB representing which LEDs
> > -               should be on
> > + *             should be on
> 
> nitpick: checkpatch complains about spaces before tabs here.
> 
> I amended locally and will push the fixed version.

Those are usually highlighted in my editor.

I wonder how I missed them.

Thanks for cleaning it up though.
diff mbox series

Patch

diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c
index d5b7a696a68c5..d0c640be8a885 100644
--- a/drivers/hid/usbhid/usbkbd.c
+++ b/drivers/hid/usbhid/usbkbd.c
@@ -63,7 +63,7 @@  static const unsigned char usb_kbd_keycode[256] = {
  *		new key is pressed or a key that was pressed is released.
  * @led:	URB for sending LEDs (e.g. numlock, ...)
  * @newleds:	data that will be sent with the @led URB representing which LEDs
- 		should be on
+ *  		should be on
  * @name:	Name of the keyboard. @dev's name field points to this buffer
  * @phys:	Physical path of the keyboard. @dev's phys field points to this
  *		buffer