diff mbox series

Input: twl4030_keypad - Fix missing IRQF_ONESHOT as only threaded handler

Message ID 20210416025706.11214-1-zhuguangqing83@gmail.com (mailing list archive)
State New, archived
Headers show
Series Input: twl4030_keypad - Fix missing IRQF_ONESHOT as only threaded handler | expand

Commit Message

guangqing zhu April 16, 2021, 2:57 a.m. UTC 
From: Guangqing Zhu <zhuguangqing83@gmail.com>

Coccinelle noticed:
drivers/input/keyboard/twl4030_keypad.c:413:9-34: ERROR: Threaded IRQ with
no primary handler requested without IRQF_ONESHOT

Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
---
 drivers/input/keyboard/twl4030_keypad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Felipe Balbi April 16, 2021, 10:38 a.m. UTC | #1 
zhuguangqing83@gmail.com writes:

> From: Guangqing Zhu <zhuguangqing83@gmail.com>
>
> Coccinelle noticed:
> drivers/input/keyboard/twl4030_keypad.c:413:9-34: ERROR: Threaded IRQ with
> no primary handler requested without IRQF_ONESHOT
>
> Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>

Reviewed-by: Felipe Balbi <balbi@kernel.org>
diff mbox series

Patch

diff --git a/drivers/input/keyboard/twl4030_keypad.c b/drivers/input/keyboard/twl4030_keypad.c
index 77e0743a3cf8..05057ebb1ab2 100644
--- a/drivers/input/keyboard/twl4030_keypad.c
+++ b/drivers/input/keyboard/twl4030_keypad.c
@@ -411,7 +411,7 @@  static int twl4030_kp_probe(struct platform_device *pdev)
 	 * NOTE:  we assume this host is wired to TWL4040 INT1, not INT2 ...
 	 */
 	error = devm_request_threaded_irq(&pdev->dev, kp->irq, NULL, do_kp_irq,
-					  0, pdev->name, kp);
+					  IRQF_ONESHOT, pdev->name, kp);
 	if (error) {
 		dev_info(kp->dbg_dev, "request_irq failed for irq no=%d: %d\n",
 			kp->irq, error);