diff mbox series

[1/1] Input: olpc_apsp - Remove redundant error printing in olpc_apsp_probe()

Message ID 20210511111321.5209-1-thunder.leizhen@huawei.com (mailing list archive)
State New
Headers show
Series [1/1] Input: olpc_apsp - Remove redundant error printing in olpc_apsp_probe() | expand

Commit Message

Zhen Lei May 11, 2021, 11:13 a.m. UTC
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 drivers/input/serio/olpc_apsp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/drivers/input/serio/olpc_apsp.c b/drivers/input/serio/olpc_apsp.c
index 59de8d9b6710e34..ef0a16d4c8f46de 100644
--- a/drivers/input/serio/olpc_apsp.c
+++ b/drivers/input/serio/olpc_apsp.c
@@ -180,10 +180,8 @@  static int olpc_apsp_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	priv->base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(priv->base)) {
-		dev_err(&pdev->dev, "Failed to map WTM registers\n");
+	if (IS_ERR(priv->base))
 		return PTR_ERR(priv->base);
-	}
 
 	priv->irq = platform_get_irq(pdev, 0);
 	if (priv->irq < 0)