diff mbox series

[v5,1/8] dt-bindings: input: touchscreen: iqs626a: chnage node name to pass validation

Message ID 20210521044525.7397-2-o.rempel@pengutronix.de (mailing list archive)
State Superseded
Headers show
Series add z1 and z2 channels support for resistive-adc-touch driver | expand

Commit Message

Oleksij Rempel May 21, 2021, 4:45 a.m. UTC
Change node name from iqs626a -> touchscreen to pass dt_binding_check.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 Documentation/devicetree/bindings/input/iqs626a.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jonathan Cameron May 21, 2021, 4:26 p.m. UTC | #1
Change typo in title.


On Fri, 21 May 2021 06:45:18 +0200
Oleksij Rempel <o.rempel@pengutronix.de> wrote:

> Change node name from iqs626a -> touchscreen to pass dt_binding_check.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/input/iqs626a.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/iqs626a.yaml b/Documentation/devicetree/bindings/input/iqs626a.yaml
> index 0cb736c541c9..ea4f04e2d3ad 100644
> --- a/Documentation/devicetree/bindings/input/iqs626a.yaml
> +++ b/Documentation/devicetree/bindings/input/iqs626a.yaml
> @@ -751,7 +751,7 @@ examples:
>              #address-cells = <1>;
>              #size-cells = <0>;
>  
> -            iqs626a@44 {
> +            touchscreen@44 {
>                      #address-cells = <1>;
>                      #size-cells = <0>;
>
Rob Herring May 21, 2021, 5:08 p.m. UTC | #2
On Fri, 21 May 2021 06:45:18 +0200, Oleksij Rempel wrote:
> Change node name from iqs626a -> touchscreen to pass dt_binding_check.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/input/iqs626a.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Jeff LaBundy May 23, 2021, 3:09 a.m. UTC | #3
Hi Oleksij and Rob,

I disagree with this patch; the device is neither a touchscreen nor
does the example include any touchscreen properties. The end result
is confusing.

On Fri, May 21, 2021 at 12:08:30PM -0500, Rob Herring wrote:
> On Fri, 21 May 2021 06:45:18 +0200, Oleksij Rempel wrote:
> > Change node name from iqs626a -> touchscreen to pass dt_binding_check.
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> >  Documentation/devicetree/bindings/input/iqs626a.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> 
> Acked-by: Rob Herring <robh@kernel.org>

What is the failure returned by dt_binding_check? Is it because of
the reference to touchscreen.yaml? If so, I'd rather we update the
tool instead of appease it.

This device leverages the touchscreen helpers for axis swapping or
inversion in 'trackpad' mode, which any input device is free to do
starting with 5.13.

Kind regards,
Jeff LaBundy
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/input/iqs626a.yaml b/Documentation/devicetree/bindings/input/iqs626a.yaml
index 0cb736c541c9..ea4f04e2d3ad 100644
--- a/Documentation/devicetree/bindings/input/iqs626a.yaml
+++ b/Documentation/devicetree/bindings/input/iqs626a.yaml
@@ -751,7 +751,7 @@  examples:
             #address-cells = <1>;
             #size-cells = <0>;
 
-            iqs626a@44 {
+            touchscreen@44 {
                     #address-cells = <1>;
                     #size-cells = <0>;