| Message ID | 20210916153126.13886-1-caihuoqing@baidu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Input: bcm_iproc_tsc - Make use of the helper function dev_err_probe() | expand |
On 9/16/2021 8:31 AM, Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> > --- > drivers/input/touchscreen/bcm_iproc_tsc.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/input/touchscreen/bcm_iproc_tsc.c b/drivers/input/touchscreen/bcm_iproc_tsc.c > index 7de1fd24ce36..c6aaeaee1d12 100644 > --- a/drivers/input/touchscreen/bcm_iproc_tsc.c > +++ b/drivers/input/touchscreen/bcm_iproc_tsc.c > @@ -441,12 +441,9 @@ static int iproc_ts_probe(struct platform_device *pdev) > } > > priv->tsc_clk = devm_clk_get(&pdev->dev, "tsc_clk"); > - if (IS_ERR(priv->tsc_clk)) { > - error = PTR_ERR(priv->tsc_clk); > - dev_err(&pdev->dev, > - "failed getting clock tsc_clk: %d\n", error); > - return error; > - } > + if (IS_ERR(priv->tsc_clk)) > + return dev_err_probe(&pdev->dev, PTR_ERR(priv->tsc_clk), > + "failed getting clock tsc_clk\n"); > > priv->pdev = pdev; > error = iproc_get_tsc_config(&pdev->dev, priv); > Improvement looks good to me. Thanks. Acked-by: Ray Jui <ray.jui@broadcom.com>
diff --git a/drivers/input/touchscreen/bcm_iproc_tsc.c b/drivers/input/touchscreen/bcm_iproc_tsc.c index 7de1fd24ce36..c6aaeaee1d12 100644 --- a/drivers/input/touchscreen/bcm_iproc_tsc.c +++ b/drivers/input/touchscreen/bcm_iproc_tsc.c @@ -441,12 +441,9 @@ static int iproc_ts_probe(struct platform_device *pdev) } priv->tsc_clk = devm_clk_get(&pdev->dev, "tsc_clk"); - if (IS_ERR(priv->tsc_clk)) { - error = PTR_ERR(priv->tsc_clk); - dev_err(&pdev->dev, - "failed getting clock tsc_clk: %d\n", error); - return error; - } + if (IS_ERR(priv->tsc_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(priv->tsc_clk), + "failed getting clock tsc_clk\n"); priv->pdev = pdev; error = iproc_get_tsc_config(&pdev->dev, priv);
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> --- drivers/input/touchscreen/bcm_iproc_tsc.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)