diff mbox series

HID: thrustmaster: Initialized pointer twi with NULL rather than 0

Message ID 20210925222216.182099-1-colin.king@canonical.com (mailing list archive)
State New, archived
Delegated to: Jiri Kosina
Headers show
Series HID: thrustmaster: Initialized pointer twi with NULL rather than 0 | expand

Commit Message

Colin King Sept. 25, 2021, 10:22 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

Pointers should be initialized with NULL rather than 0. Fix this.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/hid/hid-thrustmaster.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Colin King Sept. 25, 2021, 10:26 p.m. UTC | #1
On 25/09/2021 23:22, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Pointers should be initialized with NULL rather than 0. Fix this.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/hid/hid-thrustmaster.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c
> index d44550aa8805..aa874f075bf9 100644
> --- a/drivers/hid/hid-thrustmaster.c
> +++ b/drivers/hid/hid-thrustmaster.c
> @@ -205,7 +205,7 @@ static void thrustmaster_model_handler(struct urb *urb)
>  	struct tm_wheel *tm_wheel = hid_get_drvdata(hdev);
>  	uint16_t model = 0;
>  	int i, ret;
> -	const struct tm_wheel_info *twi = 0;
> +	const struct tm_wheel_info *twi = NULL;
>  
>  	if (urb->status) {
>  		hid_err(hdev, "URB to get model id failed with error %d\n", urb->status);
> 

NACK, I spotted another pointer than needs the same change, will send a V2.
diff mbox series

Patch

diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c
index d44550aa8805..aa874f075bf9 100644
--- a/drivers/hid/hid-thrustmaster.c
+++ b/drivers/hid/hid-thrustmaster.c
@@ -205,7 +205,7 @@  static void thrustmaster_model_handler(struct urb *urb)
 	struct tm_wheel *tm_wheel = hid_get_drvdata(hdev);
 	uint16_t model = 0;
 	int i, ret;
-	const struct tm_wheel_info *twi = 0;
+	const struct tm_wheel_info *twi = NULL;
 
 	if (urb->status) {
 		hid_err(hdev, "URB to get model id failed with error %d\n", urb->status);