diff mbox series

hid: playstation: add LEDS_CLASS dependency

Message ID 20211029114044.1058958-1-arnd@kernel.org (mailing list archive)
State New, archived
Delegated to: Jiri Kosina
Headers show
Series hid: playstation: add LEDS_CLASS dependency | expand

Commit Message

Arnd Bergmann Oct. 29, 2021, 11:40 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The new LED support causes a link failure when the LEDS subsystem
is in a loadable module and the playstation HID driver is built-in:

ld.lld: error: undefined symbol: devm_led_classdev_multicolor_register_ext
>>> referenced by hid-playstation.c
>>>               hid/hid-playstation.o:(ps_lightbar_register) in archive drivers/built-in.a

Add a hard Kconfig dependency on LEDS_CLASS, but allow building with
the multicolor support disabled, as this is apparently meant as an
optional interface.

Fixes: 8c0ab553b072 ("HID: playstation: expose DualSense player LEDs through LED class.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/hid/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jiri Kosina Nov. 1, 2021, 2:37 p.m. UTC | #1 
On Fri, 29 Oct 2021, Roderick.Colenbrander@sony.com wrote:

> Thanks you beat me into looking at this. Something like this got dropped through all the iterations this went through earlier this year.
> 
> I would maybe prefer to make this a hard dependency on multicolor. If 
> conditional not all devices will enable it. We have had various issues 
> already on e.g. Android were some vendors didn't set certain options.

Ah, sorry, I've seen the mail from 0day bot first before Arnd's mail, and 
the fix (adding hard dependency on LEDS_CLASS_MULTICOLOR) is already 
pushed out.

Thanks,
diff mbox series

Patch

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index a2c3d9b7bd01..cd10c398580e 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -899,6 +899,8 @@  config HID_PLANTRONICS
 config HID_PLAYSTATION
 	tristate "PlayStation HID Driver"
 	depends on HID
+	depends on LEDS_CLASS
+	depends on LEDS_CLASS_MULTICOLOR || !LEDS_CLASS_MULTICOLOR
 	select CRC32
 	select POWER_SUPPLY
 	help