| Message ID | 20211203075927.2829218-1-gregkh@linuxfoundation.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | d080811f27936f712f619f847389f403ac873b8f |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: add USB_HID dependancy to hid-chicony | expand |
On Fri, Dec 3, 2021 at 8:59 AM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > The chicony HID driver only controls USB devices, yet did not have a > dependancy on USB_HID. This causes build errors on some configurations > like sparc when building due to new changes to the chicony driver. > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Cc: Jiri Kosina <jikos@kernel.org> > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Applied to for-5.16/upstream-fixes in hid.git thanks Cheers, Benjamin > --- > drivers/hid/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index 828c2995ec34..e9bc8efed5a1 100644 > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -207,7 +207,7 @@ config HID_CHERRY > > config HID_CHICONY > tristate "Chicony devices" > - depends on HID > + depends on USB_HID > default !EXPERT > help > Support for Chicony Tactical pad and special keys on Chicony keyboards. > -- > 2.34.1 >
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 828c2995ec34..e9bc8efed5a1 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -207,7 +207,7 @@ config HID_CHERRY config HID_CHICONY tristate "Chicony devices" - depends on HID + depends on USB_HID default !EXPERT help Support for Chicony Tactical pad and special keys on Chicony keyboards.
The chicony HID driver only controls USB devices, yet did not have a dependancy on USB_HID. This causes build errors on some configurations like sparc when building due to new changes to the chicony driver. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Jiri Kosina <jikos@kernel.org> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/hid/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)