diff mbox series

[4/5] Input: goodix - 2 small fixes for pen support

Message ID 20211212124242.81019-5-hdegoede@redhat.com (mailing list archive)
State Accepted
Commit 71f4ecd5ee8463bd47783bb0a37516aee3e0fd38
Headers show
Series Input: goodix - Various fixes and improvements | expand

Commit Message

Hans de Goede Dec. 12, 2021, 12:42 p.m. UTC 
2 small fixes for pen support

1. Set the id.vendor field for the pen input_dev
2. Fix a typo in a comment

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/input/touchscreen/goodix.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Dmitry Torokhov Dec. 13, 2021, 4:56 a.m. UTC | #1 
On Sun, Dec 12, 2021 at 01:42:41PM +0100, Hans de Goede wrote:
> 2 small fixes for pen support
> 
> 1. Set the id.vendor field for the pen input_dev
> 2. Fix a typo in a comment
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Applied, thank you.
diff mbox series

Patch

diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index 84406789da2d..04baf5a770f5 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -326,6 +326,7 @@  static struct input_dev *goodix_create_pen_input(struct goodix_ts_data *ts)
 	input->name = "Goodix Active Pen";
 	input->phys = "input/pen";
 	input->id.bustype = BUS_I2C;
+	input->id.vendor = 0x0416;
 	if (kstrtou16(ts->id, 10, &input->id.product))
 		input->id.product = 0x1001;
 	input->id.version = ts->version;
@@ -468,7 +469,7 @@  static void goodix_process_events(struct goodix_ts_data *ts)
 	if (touch_num == 1 && (point_data[1] & 0x80)) {
 		goodix_ts_report_pen_down(ts, point_data);
 		goodix_ts_release_keys(ts);
-		goto sync; /* Release any previousle registered touches */
+		goto sync; /* Release any previously registered touches */
 	} else {
 		goodix_ts_report_pen_up(ts);
 	}