| Message ID | 20220117060759.84924-1-julianbraha@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 6100a19c4fcfe154dd32f8a8ef4e8c0b1f607c75 |
| Headers | show |
| Series | input: fix Kconfig dependency on IIO_BUFFER | expand |
diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig index 3b23078bc7b5..db4135bbd279 100644 --- a/drivers/input/joystick/Kconfig +++ b/drivers/input/joystick/Kconfig @@ -46,6 +46,7 @@ config JOYSTICK_A3D config JOYSTICK_ADC tristate "Simple joystick connected over ADC" depends on IIO + select IIO_BUFFER select IIO_BUFFER_CB help Say Y here if you have a simple joystick connected over ADC.
When JOYSTICK_ADC is enabled, and IIO_BUFFER is disabled, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for IIO_BUFFER_CB Depends on [n]: IIO [=y] && IIO_BUFFER [=n] Selected by [y]: - JOYSTICK_ADC [=y] && !UML && INPUT [=y] && INPUT_JOYSTICK [=y] && IIO [=y] This is because JOYSTICK_ADC selects IIO_BUFFER_CB without selecting or depending on IIO_BUFFER, despite IIO_BUFFER_CB depending on IIO_BUFFER. This unmet dependency bug was detected by Kismet, a static analysis tool for Kconfig. Please advise if this is not the appropriate solution. Signed-off-by: Julian Braha <julianbraha@gmail.com> --- drivers/input/joystick/Kconfig | 1 + 1 file changed, 1 insertion(+)