| Message ID | 20220122094827.684542-1-dzm91@hust.edu.cn (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 817b8b9c5396d2b2d92311b46719aad5d3339dbe |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | hid: elo: fix memory leak in elo_probe | expand |
On Sat, 22 Jan 2022, Dongliang Mu wrote: > From: Dongliang Mu <mudongliangabcd@gmail.com> > > When hid_parse in elo_probe fails, it forgets to call usb_put_dev to > decrease the refcount. > > Fix this by adding usb_put_dev in the error handling code of elo_probe > > Fixes: fbf42729d0e9 ("HID: elo: update the reference count of the usb device structure") > Reported-by: syzkaller <syzkaller@googlegroups.com> > Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com> > --- > drivers/hid/hid-elo.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/hid-elo.c b/drivers/hid/hid-elo.c > index 8e960d7b233b..9b42b0cdeef0 100644 > --- a/drivers/hid/hid-elo.c > +++ b/drivers/hid/hid-elo.c > @@ -262,6 +262,7 @@ static int elo_probe(struct hid_device *hdev, const struct hid_device_id *id) > > return 0; > err_free: > + usb_put_dev(udev); > kfree(priv); > return ret; Applied, thank you.
diff --git a/drivers/hid/hid-elo.c b/drivers/hid/hid-elo.c index 8e960d7b233b..9b42b0cdeef0 100644 --- a/drivers/hid/hid-elo.c +++ b/drivers/hid/hid-elo.c @@ -262,6 +262,7 @@ static int elo_probe(struct hid_device *hdev, const struct hid_device_id *id) return 0; err_free: + usb_put_dev(udev); kfree(priv); return ret; }