From patchwork Wed Feb 16 05:46:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: zhaoxiao X-Patchwork-Id: 12747967 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1B98C433EF for ; Wed, 16 Feb 2022 05:47:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344675AbiBPFrU (ORCPT ); Wed, 16 Feb 2022 00:47:20 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:35906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344669AbiBPFrU (ORCPT ); Wed, 16 Feb 2022 00:47:20 -0500 X-Greylist: delayed 801 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 15 Feb 2022 21:47:07 PST Received: from smtpproxy21.qq.com (smtpbg702.qq.com [203.205.195.102]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E4E4EBAF6 for ; Tue, 15 Feb 2022 21:47:07 -0800 (PST) X-QQ-mid: bizesmtp69t1644990406twzmpbu1 Received: from localhost.localdomain (unknown [123.114.60.34]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 16 Feb 2022 13:46:45 +0800 (CST) X-QQ-SSF: 01400000002000B0L000B00A0000000 X-QQ-FEAT: ufm+TBkikDO1VZy/15PSXYMTP/JwUeYpZvePpZiDrnel/O2Z3RiU8kZYgLbgI qf0l8KcYiQQerIVQaI6RKOZaI7QxizFji90ExM6tF9FuUieGV9jgmRxLM7eRVqsynxievBF hz3Fa9wkkN8JUCuG2lqavc/CdPZO+h4i/yBzKT1iE8b47xeA4T96spFsnwppaR1yldekV01 NyBJWzXUdZfOxpYrVo5iluSuZAfB7nSLTHKhWPdFaAhj2wzAEsQhRZznv0DOim1HA0MJZ6M bP+G2UEWXorBFUu/p2j3BzNQHuNfqpvVqILKRXW+J7DP8Pud/gyUkD0nQMOH4oEhcQ0LOPs 4Y83nfmU3BTLWLdlxK+LTtotdHIlL86KZ4bFACP X-QQ-GoodBg: 2 From: zhaoxiao To: dmitry.torokhov@gmail.com Cc: support.opensource@diasemi.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, zhaoxiao Subject: [PATCH] input: da7280: Make use of the helper function dev_err_probe() Date: Wed, 16 Feb 2022 13:46:43 +0800 Message-Id: <20220216054643.21829-1-zhaoxiao@uniontech.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybgforeign:qybgforeign6 X-QQ-Bgrelay: 1 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org devm_pwm_get() can return -EPROBE_DEFER if the pwm regulator is not ready yet. Use dev_err_probe() for pwm regulator resources to indicate the deferral reason when waiting for the resource to come up. Signed-off-by: zhaoxiao --- drivers/input/misc/da7280.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/input/misc/da7280.c b/drivers/input/misc/da7280.c index b08610d6e575..16b364a4ef5e 100644 --- a/drivers/input/misc/da7280.c +++ b/drivers/input/misc/da7280.c @@ -1165,12 +1165,9 @@ static int da7280_probe(struct i2c_client *client, if (haptics->const_op_mode == DA7280_PWM_MODE) { haptics->pwm_dev = devm_pwm_get(dev, NULL); - error = PTR_ERR_OR_ZERO(haptics->pwm_dev); - if (error) { - if (error != -EPROBE_DEFER) - dev_err(dev, "Unable to request PWM: %d\n", - error); - return error; + if (IS_ERR(haptics->pwm_dev)) + return dev_err_probe(dev, PTR_ERR(haptics->pwm_dev), + "Unable to request PWM\n"); } /* Sync up PWM state and ensure it is off. */