| Message ID | 20220224035819.1593730-1-davidgow@google.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Input: samsung-keypad - Properly state IOMEM dependency | expand |
On 24/02/2022 03:58, David Gow wrote: > Make the samsung-keypad driver explicitly depend on CONFIG_IOMEM, as it > calls devm_ioremap(). This prevents compile errors in some configs (e.g, > allyesconfig/randconfig under UML): > > /usr/bin/ld: drivers/input/keyboard/samsung-keypad.o: in function `samsung_keypad_probe': > samsung-keypad.c:(.text+0xc60): undefined reference to `devm_ioremap' > > Signed-off-by: David Gow <davidgow@google.com> > --- > drivers/input/keyboard/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig > index 0c607da9ee10..5c98d5f996e4 100644 > --- a/drivers/input/keyboard/Kconfig > +++ b/drivers/input/keyboard/Kconfig > @@ -556,7 +556,7 @@ config KEYBOARD_PMIC8XXX > > config KEYBOARD_SAMSUNG > tristate "Samsung keypad support" > - depends on HAVE_CLK > + depends on IOMEM && HAVE_CLK > select INPUT_MATRIXKMAP > help > Say Y here if you want to use the keypad on your Samsung mobile > Acked-By: anton ivanov <anton.ivanov@cambridgegreys.com>
diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index 0c607da9ee10..5c98d5f996e4 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -556,7 +556,7 @@ config KEYBOARD_PMIC8XXX config KEYBOARD_SAMSUNG tristate "Samsung keypad support" - depends on HAVE_CLK + depends on IOMEM && HAVE_CLK select INPUT_MATRIXKMAP help Say Y here if you want to use the keypad on your Samsung mobile
Make the samsung-keypad driver explicitly depend on CONFIG_IOMEM, as it calls devm_ioremap(). This prevents compile errors in some configs (e.g, allyesconfig/randconfig under UML): /usr/bin/ld: drivers/input/keyboard/samsung-keypad.o: in function `samsung_keypad_probe': samsung-keypad.c:(.text+0xc60): undefined reference to `devm_ioremap' Signed-off-by: David Gow <davidgow@google.com> --- drivers/input/keyboard/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)