diff mbox series

[v5,5/5] HID: google: modify HID device groups of eel

Message ID 20220228075446.466016-6-dmitry.torokhov@gmail.com (mailing list archive)
State Mainlined
Commit 8a3e634dc5a37aaa6d4876614716e84fb26dbbc0
Delegated to: Jiri Kosina
Headers show
Series Input/HID: Consolidate ChromeOS Vivaldi keyboard logic | expand

Commit Message

Dmitry Torokhov Feb. 28, 2022, 7:54 a.m. UTC 
From: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>

If HID_GROUP of eel is set to HID_GROUP_GENERIC, Whiskers Tablet Mode
Switch of eel hammer will not be detected by system because the
hid-vivaldi driver probes the device. When it is set to
HID_GROUP_VIVALDI, system will detect Whiskers Tablet Mode Switch
successfully and also support the vivaldi keyboard layout.

Tested-by: "Sean O'Brien" <seobrien@chromium.org>
Acked-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
[swboyd@chromium.org: Expand on commit text]
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20220216195901.1326924-5-swboyd@chromium.org
Patchwork-Id: 12748989
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/hid/hid-google-hammer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Boyd Feb. 28, 2022, 8:57 p.m. UTC | #1 
Quoting Dmitry Torokhov (2022-02-27 23:54:46)
> From: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
>
> If HID_GROUP of eel is set to HID_GROUP_GENERIC, Whiskers Tablet Mode
> Switch of eel hammer will not be detected by system because the
> hid-vivaldi driver probes the device. When it is set to
> HID_GROUP_VIVALDI, system will detect Whiskers Tablet Mode Switch
> successfully and also support the vivaldi keyboard layout.
>
> Tested-by: "Sean O'Brien" <seobrien@chromium.org>
> Acked-by: Jiri Kosina <jkosina@suse.cz>
> Signed-off-by: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
> [swboyd@chromium.org: Expand on commit text]
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> Link: https://lore.kernel.org/r/20220216195901.1326924-5-swboyd@chromium.org
> Patchwork-Id: 12748989

Should this patchwork id be removed?
Dmitry Torokhov March 1, 2022, 6:55 a.m. UTC | #2 
On Mon, Feb 28, 2022 at 12:57:56PM -0800, Stephen Boyd wrote:
> Quoting Dmitry Torokhov (2022-02-27 23:54:46)
> > From: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
> >
> > If HID_GROUP of eel is set to HID_GROUP_GENERIC, Whiskers Tablet Mode
> > Switch of eel hammer will not be detected by system because the
> > hid-vivaldi driver probes the device. When it is set to
> > HID_GROUP_VIVALDI, system will detect Whiskers Tablet Mode Switch
> > successfully and also support the vivaldi keyboard layout.
> >
> > Tested-by: "Sean O'Brien" <seobrien@chromium.org>
> > Acked-by: Jiri Kosina <jkosina@suse.cz>
> > Signed-off-by: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
> > [swboyd@chromium.org: Expand on commit text]
> > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> > Link: https://lore.kernel.org/r/20220216195901.1326924-5-swboyd@chromium.org
> > Patchwork-Id: 12748989
> 
> Should this patchwork id be removed?

Yeah, this is leftover from my scripts, they will drop it when applying.

Thanks.
diff mbox series

Patch

diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
index 5d774c9c596c..7fd342081183 100644
--- a/drivers/hid/hid-google-hammer.c
+++ b/drivers/hid/hid-google-hammer.c
@@ -582,7 +582,7 @@  static void hammer_remove(struct hid_device *hdev)
 static const struct hid_device_id hammer_devices[] = {
 	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
 		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_DON) },
-	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
+	{ HID_DEVICE(BUS_USB, HID_GROUP_VIVALDI,
 		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_EEL) },
 	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
 		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_HAMMER) },