| Message ID | 20220606134750.20736-1-liqiong@nfschina.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 15b28156029465e594b462e6dad459a737028697 |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | [1/2] HID: intel-ish-hid: ipc: use time_before to replace "jiffies < a" | expand |
On Mon, 2022-06-06 at 21:47 +0800, Li Qiong wrote: > time_before deals with timer wrapping correctly. > > Signed-off-by: Li Qiong <liqiong@nfschina.com> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > --- > drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel- > ish-hid/ipc/ipc.c > index 8ccb246b0114..15e14239af82 100644 > --- a/drivers/hid/intel-ish-hid/ipc/ipc.c > +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c > @@ -578,7 +578,7 @@ static void _ish_sync_fw_clock(struct > ishtp_device *dev) > static unsigned long prev_sync; > uint64_t usec; > > - if (prev_sync && jiffies - prev_sync < 20 * HZ) > + if (prev_sync && time_before(jiffies, prev_sync + 20 * HZ)) > return; > > prev_sync = jiffies;
On Mon, 6 Jun 2022, Li Qiong wrote: > time_before deals with timer wrapping correctly. > > Signed-off-by: Li Qiong <liqiong@nfschina.com> > --- > drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c > index 8ccb246b0114..15e14239af82 100644 > --- a/drivers/hid/intel-ish-hid/ipc/ipc.c > +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c > @@ -578,7 +578,7 @@ static void _ish_sync_fw_clock(struct ishtp_device *dev) > static unsigned long prev_sync; > uint64_t usec; > > - if (prev_sync && jiffies - prev_sync < 20 * HZ) > + if (prev_sync && time_before(jiffies, prev_sync + 20 * HZ)) > return; Applied, thanks.
diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c index 8ccb246b0114..15e14239af82 100644 --- a/drivers/hid/intel-ish-hid/ipc/ipc.c +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c @@ -578,7 +578,7 @@ static void _ish_sync_fw_clock(struct ishtp_device *dev) static unsigned long prev_sync; uint64_t usec; - if (prev_sync && jiffies - prev_sync < 20 * HZ) + if (prev_sync && time_before(jiffies, prev_sync + 20 * HZ)) return; prev_sync = jiffies;
time_before deals with timer wrapping correctly. Signed-off-by: Li Qiong <liqiong@nfschina.com> --- drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)