[v4,4/4] input: touchscreen: elants_i2c: Add eth3915n touchscreen chip

Commit Message

Yunlong Jia Sept. 22, 2022, 10:21 a.m. UTC

The ekth3915 and ekth3500 are almost the same.

Signed-off-by: Yunlong Jia <[e-mail]>
Reviewed-by: Douglas Anderson <[e-mail]>

---

(no changes since v1)

 drivers/input/touchscreen/elants_i2c.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Doug Anderson Sept. 22, 2022, 4:35 p.m. UTC | #1

Hi,

On Thu, Sep 22, 2022 at 3:23 AM Yunlong Jia <[e-mail]> wrote:
>
> The ekth3915 and ekth3500 are almost the same.
>
> Signed-off-by: Yunlong Jia <[e-mail]>
> Reviewed-by: Douglas Anderson <[e-mail]>

You shouldn't have added my Reviewed-by here. I haven't seen this patch before.

Also: you should drop this patch. The way we've specified it in the
bindings you can rely on the "fallback" compatible string for the 3500
to handle things.

Patch

diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
index c9dd703b0c7d8..a21c9c9ed4d78 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -133,6 +133,7 @@ 
 enum elants_chip_id {
 	EKTH3500,
 	EKTF3624,
+	EKTH3915,
 };
 
 enum elants_state {
@@ -664,6 +665,7 @@  static int elants_i2c_initialize(struct elants_data *ts)
 
 	switch (ts->chip_id) {
 	case EKTH3500:
+	case EKTH3915:
 		if (!error)
 			error = elants_i2c_query_ts_info_ekth(ts);
 		break;
@@ -1686,6 +1688,7 @@  static const struct i2c_device_id elants_i2c_id[] = {
 	{ DEVICE_NAME, EKTH3500 },
 	{ "ekth3500", EKTH3500 },
 	{ "ektf3624", EKTF3624 },
+	{ "ekth3915", EKTH3915 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, elants_i2c_id);
@@ -1702,6 +1705,7 @@  MODULE_DEVICE_TABLE(acpi, elants_acpi_id);
 static const struct of_device_id elants_of_match[] = {
 	{ .compatible = "elan,ekth3500", .data = (void *)EKTH3500 },
 	{ .compatible = "elan,ektf3624", .data = (void *)EKTF3624 },
+	{ .compatible = "elan,ekth3915", .data = (void *)EKTH3915 },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, elants_of_match);