| Message ID | 20221012202341.295351-2-job@noorman.info (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add Himax hx83112b touchscreen driver | expand |
On Wed, 12 Oct 2022 20:24:06 +0000, Job Noorman wrote: > This patch adds device tree bindings for Himax 83112b touchscreen > devices. > > Signed-off-by: Job Noorman <job@noorman.info> > --- > .../input/touchscreen/himax,hx83112b.yaml | 61 +++++++++++++++++++ > MAINTAINERS | 6 ++ > 2 files changed, 67 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
Hi Rob, Thanks for you review! On Thu Oct 13, 2022 at 10:25 PM CEST, Rob Herring wrote: > On Wed, 12 Oct 2022 20:24:06 +0000, Job Noorman wrote: > > This patch adds device tree bindings for Himax 83112b touchscreen > > devices. > > > > Signed-off-by: Job Noorman <job@noorman.info> > > --- > > .../input/touchscreen/himax,hx83112b.yaml | 61 +++++++++++++++++++ > > MAINTAINERS | 6 ++ > > 2 files changed, 67 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml > > > > Reviewed-by: Rob Herring <robh@kernel.org> The next version of this patch will make the properties touchscreen-size-{x,y} required. Can I still attach your "Reviewed-by" tag to this updated patch or would you like to have a look at it first? Kind regards, Job
diff --git a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml new file mode 100644 index 000000000000..c10c82415401 --- /dev/null +++ b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/touchscreen/himax,hx83112b.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Himax hx83112b touchscreen controller bindings + +maintainers: + - Job Noorman <job@noorman.info> + +allOf: + - $ref: touchscreen.yaml# + +properties: + compatible: + enum: + - himax,hx83112b + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + reset-gpios: + maxItems: 1 + + touchscreen-inverted-x: true + touchscreen-inverted-y: true + touchscreen-size-x: true + touchscreen-size-y: true + touchscreen-swapped-x-y: true + +additionalProperties: false + +required: + - compatible + - reg + - interrupts + - reset-gpios + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/gpio/gpio.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + touchscreen@48 { + compatible = "himax,hx83112b"; + reg = <0x48>; + interrupt-parent = <&tlmm>; + interrupts = <65 IRQ_TYPE_LEVEL_LOW>; + touchscreen-size-x = <1080>; + touchscreen-size-y = <2160>; + reset-gpios = <&tlmm 64 GPIO_ACTIVE_LOW>; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index 9ddcc242081c..2418bffe9187 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9094,6 +9094,12 @@ W: http://www.highpoint-tech.com F: Documentation/scsi/hptiop.rst F: drivers/scsi/hptiop.c +HIMAX HX83112B TOUCHSCREEN SUPPORT +M: Job Noorman <job@noorman.info> +L: linux-input@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml + HIPPI M: Jes Sorensen <jes@trained-monkey.org> L: linux-hippi@sunsite.dk
This patch adds device tree bindings for Himax 83112b touchscreen devices. Signed-off-by: Job Noorman <job@noorman.info> --- .../input/touchscreen/himax,hx83112b.yaml | 61 +++++++++++++++++++ MAINTAINERS | 6 ++ 2 files changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml -- 2.38.0