| Message ID | 20221117121322.5608-1-marcus.folkesson@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 989f7cc94f1174269282a4a46bb735c7f11527de |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | [RESEND] HID: hid-alps: use default remove for hid device | expand |
On Thu, 17 Nov 2022, Marcus Folkesson wrote: > hid_device_remove() will call hid_hw_stop() as default .remove function > if no function is specified. > > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> > --- > drivers/hid/hid-alps.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c > index 2b986d0dbde4..9abaff6f3afb 100644 > --- a/drivers/hid/hid-alps.c > +++ b/drivers/hid/hid-alps.c > @@ -820,11 +820,6 @@ static int alps_probe(struct hid_device *hdev, const struct hid_device_id *id) > return 0; > } > > -static void alps_remove(struct hid_device *hdev) > -{ > - hid_hw_stop(hdev); > -} > - > static const struct hid_device_id alps_id[] = { > { HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY, > USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_DUAL) }, > @@ -840,7 +835,6 @@ static struct hid_driver alps_driver = { > .name = "hid-alps", > .id_table = alps_id, > .probe = alps_probe, > - .remove = alps_remove, > .raw_event = alps_raw_event, > .input_mapping = alps_input_mapping, > .input_configured = alps_input_configured, Applied, thanks.
diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c index 2b986d0dbde4..9abaff6f3afb 100644 --- a/drivers/hid/hid-alps.c +++ b/drivers/hid/hid-alps.c @@ -820,11 +820,6 @@ static int alps_probe(struct hid_device *hdev, const struct hid_device_id *id) return 0; } -static void alps_remove(struct hid_device *hdev) -{ - hid_hw_stop(hdev); -} - static const struct hid_device_id alps_id[] = { { HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY, USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_DUAL) }, @@ -840,7 +835,6 @@ static struct hid_driver alps_driver = { .name = "hid-alps", .id_table = alps_id, .probe = alps_probe, - .remove = alps_remove, .raw_event = alps_raw_event, .input_mapping = alps_input_mapping, .input_configured = alps_input_configured,
hid_device_remove() will call hid_hw_stop() as default .remove function if no function is specified. Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> --- drivers/hid/hid-alps.c | 6 ------ 1 file changed, 6 deletions(-)