| Message ID | 20221130161604.1879-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b2b80d9dd14cb5b70dc254bddbc4eea932694791 |
| Headers | show |
| Series | input/misc: wistron_btns: disable on UML | expand |
On Wed, Nov 30, 2022 at 08:16:04AM -0800, Randy Dunlap wrote: > The wistron_btns driver calls rtc_cmos_read(), which isn't > available with UML builds, so disable this driver on UML. > > Prevents this build error: > > ld: drivers/input/misc/wistron_btns.o: in function `poll_bios': > wistron_btns.c:(.text+0x4be): undefined reference to `rtc_cmos_read' > > Fixes: 0bbadafdc49d ("um: allow disabling NO_IOMEM") # v5.14+ > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Johannes Berg <johannes.berg@intel.com> > Cc: Richard Weinberger <richard@nod.at> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: Miloslav Trmac <mitr@volny.cz> > Cc: linux-input@vger.kernel.org > Cc: linux-um@lists.infradead.org Applied, thank you.
diff -- a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig --- a/drivers/input/misc/Kconfig +++ b/drivers/input/misc/Kconfig @@ -330,7 +330,7 @@ config INPUT_CPCAP_PWRBUTTON config INPUT_WISTRON_BTNS tristate "x86 Wistron laptop button interface" - depends on X86_32 + depends on X86_32 && !UML select INPUT_SPARSEKMAP select NEW_LEDS select LEDS_CLASS
The wistron_btns driver calls rtc_cmos_read(), which isn't available with UML builds, so disable this driver on UML. Prevents this build error: ld: drivers/input/misc/wistron_btns.o: in function `poll_bios': wistron_btns.c:(.text+0x4be): undefined reference to `rtc_cmos_read' Fixes: 0bbadafdc49d ("um: allow disabling NO_IOMEM") # v5.14+ Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Johannes Berg <johannes.berg@intel.com> Cc: Richard Weinberger <richard@nod.at> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Miloslav Trmac <mitr@volny.cz> Cc: linux-input@vger.kernel.org Cc: linux-um@lists.infradead.org --- drivers/input/misc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)