| Message ID | 20221220154345.474596-1-hadess@hadess.net (mailing list archive) |
|---|---|
| State | In Next |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | [v2,1/3] Revert "HID: logitech-hidpp: add a module parameter to keep firmware gestures" | expand |
On Tue, Dec 20, 2022 at 4:43 PM Bastien Nocera <hadess@hadess.net> wrote: > > Now that we're in 2022, and the majority of desktop environments can and > should support touchpad gestures through libinput, remove the legacy > module parameter that made it possible to use gestures implemented in > firmware. > > This will eventually allow simplifying the driver's initialisation code. > > This reverts commit 9188dbaed68a4b23dc96eba165265c08caa7dc2a. > > Signed-off-by: Bastien Nocera <hadess@hadess.net> Applied just this one to for-6.3/logitech Cheers, Benjamin > --- > drivers/hid/hid-logitech-hidpp.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c > index 08ad19097e9e..7f9187201913 100644 > --- a/drivers/hid/hid-logitech-hidpp.c > +++ b/drivers/hid/hid-logitech-hidpp.c > @@ -32,11 +32,6 @@ MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Benjamin Tissoires <benjamin.tissoires@gmail.com>"); > MODULE_AUTHOR("Nestor Lopez Casado <nlopezcasad@logitech.com>"); > > -static bool disable_raw_mode; > -module_param(disable_raw_mode, bool, 0644); > -MODULE_PARM_DESC(disable_raw_mode, > - "Disable Raw mode reporting for touchpads and keep firmware gestures."); > - > static bool disable_tap_to_click; > module_param(disable_tap_to_click, bool, 0644); > MODULE_PARM_DESC(disable_tap_to_click, > @@ -4355,11 +4350,6 @@ static int hidpp_probe(struct hid_device *hdev, const struct hid_device_id *id) > hidpp_application_equals(hdev, HID_GD_KEYBOARD)) > hidpp->quirks |= HIDPP_QUIRK_HIDPP_CONSUMER_VENDOR_KEYS; > > - if (disable_raw_mode) { > - hidpp->quirks &= ~HIDPP_QUIRK_CLASS_WTP; > - hidpp->quirks &= ~HIDPP_QUIRK_NO_HIDINPUT; > - } > - > if (hidpp->quirks & HIDPP_QUIRK_CLASS_WTP) { > ret = wtp_allocate(hdev, id); > if (ret) > -- > 2.38.1 >
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 08ad19097e9e..7f9187201913 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -32,11 +32,6 @@ MODULE_LICENSE("GPL"); MODULE_AUTHOR("Benjamin Tissoires <benjamin.tissoires@gmail.com>"); MODULE_AUTHOR("Nestor Lopez Casado <nlopezcasad@logitech.com>"); -static bool disable_raw_mode; -module_param(disable_raw_mode, bool, 0644); -MODULE_PARM_DESC(disable_raw_mode, - "Disable Raw mode reporting for touchpads and keep firmware gestures."); - static bool disable_tap_to_click; module_param(disable_tap_to_click, bool, 0644); MODULE_PARM_DESC(disable_tap_to_click, @@ -4355,11 +4350,6 @@ static int hidpp_probe(struct hid_device *hdev, const struct hid_device_id *id) hidpp_application_equals(hdev, HID_GD_KEYBOARD)) hidpp->quirks |= HIDPP_QUIRK_HIDPP_CONSUMER_VENDOR_KEYS; - if (disable_raw_mode) { - hidpp->quirks &= ~HIDPP_QUIRK_CLASS_WTP; - hidpp->quirks &= ~HIDPP_QUIRK_NO_HIDINPUT; - } - if (hidpp->quirks & HIDPP_QUIRK_CLASS_WTP) { ret = wtp_allocate(hdev, id); if (ret)
Now that we're in 2022, and the majority of desktop environments can and should support touchpad gestures through libinput, remove the legacy module parameter that made it possible to use gestures implemented in firmware. This will eventually allow simplifying the driver's initialisation code. This reverts commit 9188dbaed68a4b23dc96eba165265c08caa7dc2a. Signed-off-by: Bastien Nocera <hadess@hadess.net> --- drivers/hid/hid-logitech-hidpp.c | 10 ---------- 1 file changed, 10 deletions(-)