| Message ID | 20230120124544.5993-4-l.ellero@asem.it (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Input: ads7846 - fix support for ADS7845 | expand |
On Fri, Jan 20, 2023 at 01:45:44PM +0100, Luca Ellero wrote: > To discard false readings, one should use "ti,penirq-recheck-delay-usecs". > Checking get_pendown_state() at the beginning, most of the time fails > causing malfunctioning. Should it have a Fixes: tag? > Signed-off-by: Luca Ellero <l.ellero@asem.it>
diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c index 15da1047a577..17f11bce8113 100644 --- a/drivers/input/touchscreen/ads7846.c +++ b/drivers/input/touchscreen/ads7846.c @@ -843,14 +843,8 @@ static void ads7846_report_state(struct ads7846 *ts) if (x == MAX_12BIT) x = 0; - if (ts->model == 7843) { + if (ts->model == 7843 || ts->model == 7845) { Rt = ts->pressure_max / 2; - } else if (ts->model == 7845) { - if (get_pendown_state(ts)) - Rt = ts->pressure_max / 2; - else - Rt = 0; - dev_vdbg(&ts->spi->dev, "x/y: %d/%d, PD %d\n", x, y, Rt); } else if (likely(x && z1)) { /* compute touch pressure resistance using equation #2 */ Rt = z2;
To discard false readings, one should use "ti,penirq-recheck-delay-usecs". Checking get_pendown_state() at the beginning, most of the time fails causing malfunctioning. Signed-off-by: Luca Ellero <l.ellero@asem.it> --- drivers/input/touchscreen/ads7846.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)