| Message ID | 20230126091825.220646-2-manuel.traut@mt.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | input: pwm-beeper: add feature to set volume level | expand |
On 26/01/2023 10:18, Manuel Traut wrote: > Converts txt binding to new YAML format. > > Signed-off-by: Manuel Traut <manuel.traut@mt.com> Thank you for your patch. There is something to discuss/improve. > diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.yaml b/Documentation/devicetree/bindings/input/pwm-beeper.yaml > new file mode 100644 > index 000000000000..351df83d5cbe > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/pwm-beeper.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/input/pwm-beeper.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" Drop quotes from both. Apologies for not noticing it earlier. > + > +title: PWM beeper > + > +maintainers: > + - Dmitry Torokhov <dmitry.torokhov@gmail.com> > + > +description: Registers a PWM device as beeper. > + > +properties: > + compatible: > + const: pwm-beeper > + > + pwms: > + maxItems: 1 > + > + amp-supply: > + description: > > + phandle to a regulator that acts as an amplifier for > + the beeper Drop "phandle to a" > + > + beeper-hz: > + description: bell frequency in Hz > + > +required: > + - compatible > + - pwms > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + beeper_amp: amplifier { > + compatible = "fixed-regulator"; > + gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>; > + }; Drop this device node, not related. > + > + beeper { > + compatible = "pwm-beeper"; > + pwms = <&pwm0>; > + amp-supply = <&beeper_amp>; > + }; Best regards, Krzysztof
On Thu, 26 Jan 2023 10:18:21 +0100, Manuel Traut wrote: > Converts txt binding to new YAML format. > > Signed-off-by: Manuel Traut <manuel.traut@mt.com> > --- > .../devicetree/bindings/input/pwm-beeper.txt | 24 ---------- > .../devicetree/bindings/input/pwm-beeper.yaml | 48 +++++++++++++++++++ > 2 files changed, 48 insertions(+), 24 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/input/pwm-beeper.txt > create mode 100644 Documentation/devicetree/bindings/input/pwm-beeper.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/input/pwm-beeper.example.dtb: /example-0/amplifier: failed to match any schema with compatible: ['fixed-regulator'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230126091825.220646-2-manuel.traut@mt.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.txt b/Documentation/devicetree/bindings/input/pwm-beeper.txt deleted file mode 100644 index 8fc0e48c20db..000000000000 --- a/Documentation/devicetree/bindings/input/pwm-beeper.txt +++ /dev/null @@ -1,24 +0,0 @@ -* PWM beeper device tree bindings - -Registers a PWM device as beeper. - -Required properties: -- compatible: should be "pwm-beeper" -- pwms: phandle to the physical PWM device - -Optional properties: -- amp-supply: phandle to a regulator that acts as an amplifier for the beeper -- beeper-hz: bell frequency in Hz - -Example: - -beeper_amp: amplifier { - compatible = "fixed-regulator"; - gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>; -}; - -beeper { - compatible = "pwm-beeper"; - pwms = <&pwm0>; - amp-supply = <&beeper_amp>; -}; diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.yaml b/Documentation/devicetree/bindings/input/pwm-beeper.yaml new file mode 100644 index 000000000000..351df83d5cbe --- /dev/null +++ b/Documentation/devicetree/bindings/input/pwm-beeper.yaml @@ -0,0 +1,48 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/input/pwm-beeper.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: PWM beeper + +maintainers: + - Dmitry Torokhov <dmitry.torokhov@gmail.com> + +description: Registers a PWM device as beeper. + +properties: + compatible: + const: pwm-beeper + + pwms: + maxItems: 1 + + amp-supply: + description: > + phandle to a regulator that acts as an amplifier for + the beeper + + beeper-hz: + description: bell frequency in Hz + +required: + - compatible + - pwms + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + beeper_amp: amplifier { + compatible = "fixed-regulator"; + gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>; + }; + + beeper { + compatible = "pwm-beeper"; + pwms = <&pwm0>; + amp-supply = <&beeper_amp>; + };
Converts txt binding to new YAML format. Signed-off-by: Manuel Traut <manuel.traut@mt.com> --- .../devicetree/bindings/input/pwm-beeper.txt | 24 ---------- .../devicetree/bindings/input/pwm-beeper.yaml | 48 +++++++++++++++++++ 2 files changed, 48 insertions(+), 24 deletions(-) delete mode 100644 Documentation/devicetree/bindings/input/pwm-beeper.txt create mode 100644 Documentation/devicetree/bindings/input/pwm-beeper.yaml