| Message ID | 20230203022758.3982393-1-vi@endrift.com (mailing list archive) |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [1/3] Input: xpad - Treat Qanba controllers as Xbox360 controllers | expand |
LGTM. For onlookers curious: the audio interface being disabled here isn't currently supported in xpad quite yet, but is supported out of tree - supposedly with plans to eventually merge it into the mainline kernel. So patch 2/3 here should be fine. Anyway, Reviewed-by: Lyude Paul <lyude@redhat.com> On Thu, 2023-02-02 at 18:27 -0800, Vicki Pfau wrote: > From: "Pierre-Loup A. Griffais" <pgriffais@valvesoftware.com> > > They act that way in PC mode. > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> > --- > drivers/input/joystick/xpad.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c > index 2959d80f7fdb..bb65c8268963 100644 > --- a/drivers/input/joystick/xpad.c > +++ b/drivers/input/joystick/xpad.c > @@ -492,6 +492,7 @@ static const struct usb_device_id xpad_table[] = { > XPAD_XBOXONE_VENDOR(0x24c6), /* PowerA Controllers */ > XPAD_XBOX360_VENDOR(0x2563), /* OneXPlayer Gamepad */ > XPAD_XBOX360_VENDOR(0x260d), /* Dareu H101 */ > + XPAD_XBOX360_VENDOR(0x2c22), /* Qanba Controllers */ > XPAD_XBOXONE_VENDOR(0x2dc8), /* 8BitDo Pro 2 Wired Controller for Xbox */ > XPAD_XBOXONE_VENDOR(0x2e24), /* Hyperkin Duke X-Box One pad */ > XPAD_XBOX360_VENDOR(0x2f24), /* GameSir Controllers */
Almost forgot to mention - the Reviewed-by here is for the whole series, not just the first patch :) On Fri, 2023-02-10 at 16:45 -0500, Lyude Paul wrote: > LGTM. For onlookers curious: the audio interface being disabled here isn't > currently supported in xpad quite yet, but is supported out of tree - > supposedly with plans to eventually merge it into the mainline kernel. So > patch 2/3 here should be fine. > > Anyway, > > Reviewed-by: Lyude Paul <lyude@redhat.com> > > On Thu, 2023-02-02 at 18:27 -0800, Vicki Pfau wrote: > > From: "Pierre-Loup A. Griffais" <pgriffais@valvesoftware.com> > > > > They act that way in PC mode. > > > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> > > --- > > drivers/input/joystick/xpad.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c > > index 2959d80f7fdb..bb65c8268963 100644 > > --- a/drivers/input/joystick/xpad.c > > +++ b/drivers/input/joystick/xpad.c > > @@ -492,6 +492,7 @@ static const struct usb_device_id xpad_table[] = { > > XPAD_XBOXONE_VENDOR(0x24c6), /* PowerA Controllers */ > > XPAD_XBOX360_VENDOR(0x2563), /* OneXPlayer Gamepad */ > > XPAD_XBOX360_VENDOR(0x260d), /* Dareu H101 */ > > + XPAD_XBOX360_VENDOR(0x2c22), /* Qanba Controllers */ > > XPAD_XBOXONE_VENDOR(0x2dc8), /* 8BitDo Pro 2 Wired Controller for Xbox */ > > XPAD_XBOXONE_VENDOR(0x2e24), /* Hyperkin Duke X-Box One pad */ > > XPAD_XBOX360_VENDOR(0x2f24), /* GameSir Controllers */ >
Hi Dmitry, it looks like this patch series has been sitting for a while now without getting any kind of feedback. Could you please take a look at this the next chance you get? On Thu, 2023-02-02 at 18:27 -0800, Vicki Pfau wrote: > From: "Pierre-Loup A. Griffais" <pgriffais@valvesoftware.com> > > They act that way in PC mode. > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> > --- > drivers/input/joystick/xpad.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c > index 2959d80f7fdb..bb65c8268963 100644 > --- a/drivers/input/joystick/xpad.c > +++ b/drivers/input/joystick/xpad.c > @@ -492,6 +492,7 @@ static const struct usb_device_id xpad_table[] = { > XPAD_XBOXONE_VENDOR(0x24c6), /* PowerA Controllers */ > XPAD_XBOX360_VENDOR(0x2563), /* OneXPlayer Gamepad */ > XPAD_XBOX360_VENDOR(0x260d), /* Dareu H101 */ > + XPAD_XBOX360_VENDOR(0x2c22), /* Qanba Controllers */ > XPAD_XBOXONE_VENDOR(0x2dc8), /* 8BitDo Pro 2 Wired Controller for Xbox */ > XPAD_XBOXONE_VENDOR(0x2e24), /* Hyperkin Duke X-Box One pad */ > XPAD_XBOX360_VENDOR(0x2f24), /* GameSir Controllers */
On Thu, Feb 02, 2023 at 06:27:56PM -0800, Vicki Pfau wrote: > From: "Pierre-Loup A. Griffais" <pgriffais@valvesoftware.com> > > They act that way in PC mode. > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> Sorry, this patch is a complete mess with regard to the sender, the author, and the person giving their signed-off-by. > --- > drivers/input/joystick/xpad.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c > index 2959d80f7fdb..bb65c8268963 100644 > --- a/drivers/input/joystick/xpad.c > +++ b/drivers/input/joystick/xpad.c > @@ -492,6 +492,7 @@ static const struct usb_device_id xpad_table[] = { > XPAD_XBOXONE_VENDOR(0x24c6), /* PowerA Controllers */ > XPAD_XBOX360_VENDOR(0x2563), /* OneXPlayer Gamepad */ > XPAD_XBOX360_VENDOR(0x260d), /* Dareu H101 */ > + XPAD_XBOX360_VENDOR(0x2c22), /* Qanba Controllers */ > XPAD_XBOXONE_VENDOR(0x2dc8), /* 8BitDo Pro 2 Wired Controller for Xbox */ > XPAD_XBOXONE_VENDOR(0x2e24), /* Hyperkin Duke X-Box One pad */ > XPAD_XBOX360_VENDOR(0x2f24), /* GameSir Controllers */ > -- > 2.39.1 > Thanks.
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index 2959d80f7fdb..bb65c8268963 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c @@ -492,6 +492,7 @@ static const struct usb_device_id xpad_table[] = { XPAD_XBOXONE_VENDOR(0x24c6), /* PowerA Controllers */ XPAD_XBOX360_VENDOR(0x2563), /* OneXPlayer Gamepad */ XPAD_XBOX360_VENDOR(0x260d), /* Dareu H101 */ + XPAD_XBOX360_VENDOR(0x2c22), /* Qanba Controllers */ XPAD_XBOXONE_VENDOR(0x2dc8), /* 8BitDo Pro 2 Wired Controller for Xbox */ XPAD_XBOXONE_VENDOR(0x2e24), /* Hyperkin Duke X-Box One pad */ XPAD_XBOX360_VENDOR(0x2f24), /* GameSir Controllers */