| Message ID | 20230206184744.3.I740d409bc5bb69bf4a7b3c4568ea6e7a92f16ccd@changeid (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | d90b98f5702dccc41a5885b65361573654fcaabf |
| Headers | show |
| Series | arm: qcom: Fix touchscreen voltage for sc7280-herobrine boards | expand |
On Mon, Feb 06, 2023 at 06:48:12PM -0800, Douglas Anderson wrote: > On never revs of sc7280-herobrine-villager (rev2+) the L3C rail is nit: s/never/newer/ no need to re-spin just for this. > provided to the touchscreen as the IO voltage rail. Let's add it in > the device tree. > > NOTE: Even though this is only really needed on rev2+ villagers (-rev0 > had non-functioning touchscreen and -rev1 had some hacky hardware > magic), it doesn't actually hurt to do this for old villager revs. As > talked about in the patch ("arm64: dts: qcom: sc7280: On QCard, > regulator L3C should be 1.8V") the L3C regulator didn't go anywhere at > all on older revs. That means that turning it on for older revs > doesn't hurt other than drawing a tiny bit of extra power. Since -rev0 > and -rev1 villagers will never make it to real customers and it's nice > not to have too many old device trees, the better tradeoff seems to be > to enable it everywhere. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi index 17553e0fd6fd..818d4046d2c7 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi @@ -55,6 +55,7 @@ ap_ts: touchscreen@10 { reset-gpios = <&tlmm 54 GPIO_ACTIVE_LOW>; vcc33-supply = <&ts_avdd>; + vccio-supply = <&ts_avccio>; }; };
On never revs of sc7280-herobrine-villager (rev2+) the L3C rail is provided to the touchscreen as the IO voltage rail. Let's add it in the device tree. NOTE: Even though this is only really needed on rev2+ villagers (-rev0 had non-functioning touchscreen and -rev1 had some hacky hardware magic), it doesn't actually hurt to do this for old villager revs. As talked about in the patch ("arm64: dts: qcom: sc7280: On QCard, regulator L3C should be 1.8V") the L3C regulator didn't go anywhere at all on older revs. That means that turning it on for older revs doesn't hurt other than drawing a tiny bit of extra power. Since -rev0 and -rev1 villagers will never make it to real customers and it's nice not to have too many old device trees, the better tradeoff seems to be to enable it everywhere. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi | 1 + 1 file changed, 1 insertion(+)