diff mbox series

Input: edt-ft5x06: Add delay after waking up

Message ID 20230505115823.545803-1-p.puschmann@pironex.com (mailing list archive)
State Accepted
Commit 5672bd308ef23b81eb40dd2963f925fd671a66c2
Headers show
Series Input: edt-ft5x06: Add delay after waking up | expand

Commit Message

Philipp Puschmann May 5, 2023, 11:58 a.m. UTC
The touch controller needs some time to wake-up after setting the wake-up
gpio. Without having a delay after wake-up probing regularly fails in
edt_ft5x06_ts_identify() with an error (i.e. EREMOTEIO) that was caused
by a failed i2c transfer.

The datasheet sets the wake-up time to 5 ms, although it is not entirely
clear.

Signed-off-by: Philipp Puschmann <p.puschmann@pironex.com>
---
 drivers/input/touchscreen/edt-ft5x06.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Dmitry Torokhov May 5, 2023, 6:48 p.m. UTC | #1
On Fri, May 05, 2023 at 01:58:24PM +0200, Philipp Puschmann wrote:
> The touch controller needs some time to wake-up after setting the wake-up
> gpio. Without having a delay after wake-up probing regularly fails in
> edt_ft5x06_ts_identify() with an error (i.e. EREMOTEIO) that was caused
> by a failed i2c transfer.
> 
> The datasheet sets the wake-up time to 5 ms, although it is not entirely
> clear.
> 
> Signed-off-by: Philipp Puschmann <p.puschmann@pironex.com>

Applied, thank you.
diff mbox series

Patch

diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index 24ab9e9f5b21..3a1a5e76cd68 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -1241,6 +1241,7 @@  static int edt_ft5x06_ts_probe(struct i2c_client *client)
 	if (tsdata->wake_gpio) {
 		usleep_range(5000, 6000);
 		gpiod_set_value_cansleep(tsdata->wake_gpio, 1);
+		usleep_range(5000, 6000);
 	}
 
 	if (tsdata->reset_gpio) {