| Message ID | 20230519090149.4407-1-yangcong5@huaqin.corp-partner.google.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: i2c-hid: goodix: Add ili9882t timing | expand |
Hi, On Fri, May 19, 2023 at 2:02 AM Cong Yang <yangcong5@huaqin.corp-partner.google.com> wrote: > > The ili9882t is a TDDI IC ((Touch with Display Driver)). It requires the > panel reset gpio to be high before i2c commands. Use a longer delay in > post_power_delay_ms to ensure the poweron sequence. > > Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com> > --- > drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 6 ++++++ > 1 file changed, 6 insertions(+) Two comments: 1. You need to submit a bindings patch to document your "ilitek,ili9882t" compatible string. 2. I would tend to add the support to the "i2c-hid-of-elan.c" driver instead of the goodix one. Probably the drivers need to combined again (I'll see if I can post a patch for that before too long), but if I were picking one I'd pick the elan one, I think. -Doug
diff --git a/drivers/hid/i2c-hid/i2c-hid-of-goodix.c b/drivers/hid/i2c-hid/i2c-hid-of-goodix.c index 0060e3dcd775..c5870b683a26 100644 --- a/drivers/hid/i2c-hid/i2c-hid-of-goodix.c +++ b/drivers/hid/i2c-hid/i2c-hid-of-goodix.c @@ -101,8 +101,14 @@ static const struct goodix_i2c_hid_timing_data goodix_gt7375p_timing_data = { .post_gpio_reset_delay_ms = 180, }; +static const struct goodix_i2c_hid_timing_data ilitek_ili9882t_timing_data = { + .post_power_delay_ms = 200, + .post_gpio_reset_delay_ms = 180, +}; + static const struct of_device_id goodix_i2c_hid_of_match[] = { { .compatible = "goodix,gt7375p", .data = &goodix_gt7375p_timing_data }, + { .compatible = "ilitek,ili9882t", .data = &ilitek_ili9882t_timing_data }, { } }; MODULE_DEVICE_TABLE(of, goodix_i2c_hid_of_match);
The ili9882t is a TDDI IC ((Touch with Display Driver)). It requires the panel reset gpio to be high before i2c commands. Use a longer delay in post_power_delay_ms to ensure the poweron sequence. Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com> --- drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 6 ++++++ 1 file changed, 6 insertions(+)