| Message ID | 20230625162131.17921-2-mavchatz@protonmail.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | [RESEND,1/2] HID: logitech-dj: Add support for new lightspeed receiver iteration | expand |
On Sun, 2023-06-25 at 16:21 +0000, Mavroudis Chatzilazaridis wrote: > This patch adds support for the Pro X Superlight. Tested over USB. Could you please list which functionality this gains the device? Battery reporting? Hi-res scrolling? Something else? > > Co-developed-by: Filipe Laíns <lains@riseup.net> > Signed-off-by: Filipe Laíns <lains@riseup.net> > Signed-off-by: Mavroudis Chatzilazaridis <mavchatz@protonmail.com> > --- > drivers/hid/hid-logitech-hidpp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid- > logitech-hidpp.c > index 5e1a412fd28f..a718535fb87d 100644 > --- a/drivers/hid/hid-logitech-hidpp.c > +++ b/drivers/hid/hid-logitech-hidpp.c > @@ -4616,6 +4616,8 @@ static const struct hid_device_id > hidpp_devices[] = { > .driver_data = HIDPP_QUIRK_CLASS_G920 | > HIDPP_QUIRK_FORCE_OUTPUT_REPORTS }, > { /* Logitech G Pro Gaming Mouse over USB */ > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) }, > + { /* Logitech G Pro X Superlight Gaming Mouse over USB */ > + HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC094) }, > > { /* G935 Gaming Headset */ > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0x0a87), > -- > 2.34.1 > >
On 2023-06-28 13:50, Bastien Nocera wrote: > On Sun, 2023-06-25 at 16:21 +0000, Mavroudis Chatzilazaridis wrote: >> This patch adds support for the Pro X Superlight. Tested over USB. > > Could you please list which functionality this gains the device? > Battery reporting? Hi-res scrolling? Something else? Sure thing. The device gains battery reporting in both wired and wireless mode. Also, without this it's not being recognized by something like Piper in wireless mode, and thus can't be configured.
On Thu, 2023-06-29 at 16:03 +0000, Mavroudis Chatzilazaridis wrote: > On 2023-06-28 13:50, Bastien Nocera wrote: > > On Sun, 2023-06-25 at 16:21 +0000, Mavroudis Chatzilazaridis wrote: > > > This patch adds support for the Pro X Superlight. Tested over > > > USB. > > > > Could you please list which functionality this gains the device? > > Battery reporting? Hi-res scrolling? Something else? > > Sure thing. The device gains battery reporting in both wired and > wireless mode. Also, without this it's not being recognized by > something > like Piper in wireless mode, and thus can't be configured. Great. Could you add that information in the commit message for a v2?
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 5e1a412fd28f..a718535fb87d 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -4616,6 +4616,8 @@ static const struct hid_device_id hidpp_devices[] = { .driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS }, { /* Logitech G Pro Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) }, + { /* Logitech G Pro X Superlight Gaming Mouse over USB */ + HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC094) }, { /* G935 Gaming Headset */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0x0a87),