| Message ID | 20230811202932.30413-1-ntonnatt@ccrma.stanford.edu (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | hid: Add "Hailuck" to the list of non-apple apple keyboards | expand |
On Fri, 11 Aug, 2023 13:29:31 -0700 "Nils Tonnaett" <ntonnatt@ccrma.Stanford.EDU> wrote: > Powzan keyboards KB750 and KB770 identify as > "Hailuck Co.,Ltd USB Keyboard". Adding "Hailuck" to the list > of non-apple apple keyboards fixes function keys for these models. > > Signed-off-by: Nils Tonnaett <ntonnatt@ccrma.stanford.edu> > --- You will likely want to resubmit this patch using "HID: apple:" in place of "hid:" in the commit message subject. https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/log/drivers/hid/hid-apple.c > drivers/hid/hid-apple.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c > index d7b932925730..6664f90cecaf 100644 > --- a/drivers/hid/hid-apple.c > +++ b/drivers/hid/hid-apple.c > @@ -343,7 +343,8 @@ static const struct apple_non_apple_keyboard non_apple_keyboards[] = { > { "SONiX USB DEVICE" }, > { "Keychron" }, > { "AONE" }, > - { "GANSS" } > + { "GANSS" }, > + { "Hailuck" } This isn't a must, but maybe it makes sense to comma terminate the last member in this array specifically if you will be resubmitting this change as a v2. This way, future keyboards added will only touch one line in the patch rather than two. > }; > > static bool apple_is_non_apple_keyboard(struct hid_device *hdev) -- Thanks, Rahul Rameshbabu
diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c index d7b932925730..6664f90cecaf 100644 --- a/drivers/hid/hid-apple.c +++ b/drivers/hid/hid-apple.c @@ -343,7 +343,8 @@ static const struct apple_non_apple_keyboard non_apple_keyboards[] = { { "SONiX USB DEVICE" }, { "Keychron" }, { "AONE" }, - { "GANSS" } + { "GANSS" }, + { "Hailuck" } }; static bool apple_is_non_apple_keyboard(struct hid_device *hdev)
Powzan keyboards KB750 and KB770 identify as "Hailuck Co.,Ltd USB Keyboard". Adding "Hailuck" to the list of non-apple apple keyboards fixes function keys for these models. Signed-off-by: Nils Tonnaett <ntonnatt@ccrma.stanford.edu> --- drivers/hid/hid-apple.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)