| Message ID | 20230917151850.62505-1-rrameshbabu@nvidia.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: nvidia-shield: Select POWER_SUPPLY Kconfig option | expand |
On Sun, 17 Sep 2023, Rahul Rameshbabu wrote: > Battery information reported by the driver depends on the power supply > subsystem. Select the required subsystem when the HID_NVIDIA_SHIELD > Kconfig option is enabled. > > Fixes: 3ab196f88237 ("HID: nvidia-shield: Add battery support for Thunderstrike") > Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com> > --- > drivers/hid/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index e11c1c803676..dc227f477601 100644 > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -792,6 +792,7 @@ config HID_NVIDIA_SHIELD > tristate "NVIDIA SHIELD devices" > depends on USB_HID > depends on BT_HIDP > + select POWER_SUPPLY Is there a reason not to do it the standard way using 'depends on', and not vice versa? Thanks,
On Mon, 18 Sep, 2023 16:56:49 +0200 Jiri Kosina <jikos@kernel.org> wrote: > On Sun, 17 Sep 2023, Rahul Rameshbabu wrote: > >> Battery information reported by the driver depends on the power supply >> subsystem. Select the required subsystem when the HID_NVIDIA_SHIELD >> Kconfig option is enabled. >> >> Fixes: 3ab196f88237 ("HID: nvidia-shield: Add battery support for Thunderstrike") >> Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com> >> --- >> drivers/hid/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig >> index e11c1c803676..dc227f477601 100644 >> --- a/drivers/hid/Kconfig >> +++ b/drivers/hid/Kconfig >> @@ -792,6 +792,7 @@ config HID_NVIDIA_SHIELD >> tristate "NVIDIA SHIELD devices" >> depends on USB_HID >> depends on BT_HIDP >> + select POWER_SUPPLY > > Is there a reason not to do it the standard way using 'depends on', and > not vice versa? I originally used 'depends on' for POWER_SUPPLY. I took a look at drivers/hid/Kconfig and saw that all modules that depended on POWER_SUPPLY in the hid subsystem used 'select' instead. I figured I should follow the trend. -- Thanks, Rahul Rameshbabu
On Mon, 18 Sep 2023, Rahul Rameshbabu wrote: > >> Battery information reported by the driver depends on the power supply > >> subsystem. Select the required subsystem when the HID_NVIDIA_SHIELD > >> Kconfig option is enabled. > >> > >> Fixes: 3ab196f88237 ("HID: nvidia-shield: Add battery support for Thunderstrike") > >> Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com> > >> --- > >> drivers/hid/Kconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > >> index e11c1c803676..dc227f477601 100644 > >> --- a/drivers/hid/Kconfig > >> +++ b/drivers/hid/Kconfig > >> @@ -792,6 +792,7 @@ config HID_NVIDIA_SHIELD > >> tristate "NVIDIA SHIELD devices" > >> depends on USB_HID > >> depends on BT_HIDP > >> + select POWER_SUPPLY > > > > Is there a reason not to do it the standard way using 'depends on', and > > not vice versa? > > I originally used 'depends on' for POWER_SUPPLY. I took a look at > drivers/hid/Kconfig and saw that all modules that depended on > POWER_SUPPLY in the hid subsystem used 'select' instead. I figured I > should follow the trend. You are right. I still don't like the fact that we are forcefully selecting POWER_SUPPLY like this, but that's a 6.7 material. Appplied, thanks.
On Wed, 04 Oct, 2023 20:49:07 +0200 Jiri Kosina <jikos@kernel.org> wrote: > On Mon, 18 Sep 2023, Rahul Rameshbabu wrote: > >> >> Battery information reported by the driver depends on the power supply >> >> subsystem. Select the required subsystem when the HID_NVIDIA_SHIELD >> >> Kconfig option is enabled. >> >> >> >> Fixes: 3ab196f88237 ("HID: nvidia-shield: Add battery support for Thunderstrike") >> >> Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com> >> >> --- >> >> drivers/hid/Kconfig | 1 + >> >> 1 file changed, 1 insertion(+) >> >> >> >> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig >> >> index e11c1c803676..dc227f477601 100644 >> >> --- a/drivers/hid/Kconfig >> >> +++ b/drivers/hid/Kconfig >> >> @@ -792,6 +792,7 @@ config HID_NVIDIA_SHIELD >> >> tristate "NVIDIA SHIELD devices" >> >> depends on USB_HID >> >> depends on BT_HIDP >> >> + select POWER_SUPPLY >> > >> > Is there a reason not to do it the standard way using 'depends on', and >> > not vice versa? >> >> I originally used 'depends on' for POWER_SUPPLY. I took a look at >> drivers/hid/Kconfig and saw that all modules that depended on >> POWER_SUPPLY in the hid subsystem used 'select' instead. I figured I >> should follow the trend. > > You are right. > > I still don't like the fact that we are forcefully selecting POWER_SUPPLY > like this, but that's a 6.7 material. I agree. This bothered me as well, so I am glad you called it out. There were some items I wanted to look at for 6.7. Do you want me to add this to some other patches I am hoping to send out or did you want to take care of this? -- Thanks, Rahul Rameshbabu
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index e11c1c803676..dc227f477601 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -792,6 +792,7 @@ config HID_NVIDIA_SHIELD tristate "NVIDIA SHIELD devices" depends on USB_HID depends on BT_HIDP + select POWER_SUPPLY help Support for NVIDIA SHIELD accessories.
Battery information reported by the driver depends on the power supply subsystem. Select the required subsystem when the HID_NVIDIA_SHIELD Kconfig option is enabled. Fixes: 3ab196f88237 ("HID: nvidia-shield: Add battery support for Thunderstrike") Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com> --- drivers/hid/Kconfig | 1 + 1 file changed, 1 insertion(+)