| Message ID | 20230920115044.53098-1-tony@atomide.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/2] dt-bindings: input: gpio-keys: Allow optional dedicated wakeirq | expand |
On Wed, 20 Sep 2023 14:50:43 +0300, Tony Lindgren wrote: > Allow configuring an optional dedicated wakeirq for gpio-keys that > some SoCs have. > > Let's use the common interrupt naming "irq" and "wakeup" that we already > have in use for some drivers and subsystems like i2c framework. > > Note that the gpio-keys interrupt property is optional. If only a gpio > property is specified, the driver tries to translate the gpio into an > interrupt. > > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > > Changes since v1: > > - Run make dt_binding_check on the binding > > - Add better checks for interrupt-names as suggested by Rob, it is > now required if two interrupts are configured > > - Add more decription entries > > - Add a new example for key-wakeup > > --- > .../devicetree/bindings/input/gpio-keys.yaml | 41 ++++++++++++++++++- > 1 file changed, 40 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/input/gpio-keys.yaml:36:13: [warning] wrong indentation: expected 14 but found 12 (indentation) ./Documentation/devicetree/bindings/input/gpio-keys.yaml:38:13: [warning] wrong indentation: expected 14 but found 12 (indentation) ./Documentation/devicetree/bindings/input/gpio-keys.yaml:47:13: [warning] wrong indentation: expected 14 but found 12 (indentation) ./Documentation/devicetree/bindings/input/gpio-keys.yaml:49:13: [warning] wrong indentation: expected 14 but found 12 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230920115044.53098-1-tony@atomide.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Wed, Sep 20, 2023 at 02:50:43PM +0300, Tony Lindgren wrote: > Allow configuring an optional dedicated wakeirq for gpio-keys that > some SoCs have. > > Let's use the common interrupt naming "irq" and "wakeup" that we already > have in use for some drivers and subsystems like i2c framework. > > Note that the gpio-keys interrupt property is optional. If only a gpio > property is specified, the driver tries to translate the gpio into an > interrupt. > > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > > Changes since v1: > > - Run make dt_binding_check on the binding > > - Add better checks for interrupt-names as suggested by Rob, it is > now required if two interrupts are configured > > - Add more decription entries > > - Add a new example for key-wakeup > > --- > .../devicetree/bindings/input/gpio-keys.yaml | 41 ++++++++++++++++++- > 1 file changed, 40 insertions(+), 1 deletion(-) With the indentation fixed, Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/input/gpio-keys.yaml b/Documentation/devicetree/bindings/input/gpio-keys.yaml --- a/Documentation/devicetree/bindings/input/gpio-keys.yaml +++ b/Documentation/devicetree/bindings/input/gpio-keys.yaml @@ -31,7 +31,23 @@ patternProperties: maxItems: 1 interrupts: - maxItems: 1 + oneOf: + - items: + - description: Optional key interrupt or wakeup interrupt + - items: + - description: Key interrupt + - description: Wakeup interrupt + + interrupt-names: + description: + Optional interrupt names, can be used to specify a separate dedicated + wake-up interrupt in addition to the gpio irq + oneOf: + - items: + - enum: [ irq, wakeup ] + - items: + - const: irq + - const: wakeup label: description: Descriptive name of the key. @@ -97,6 +113,20 @@ patternProperties: - required: - gpios + allOf: + - if: + properties: + interrupts: + minItems: 2 + required: + - interrupts + then: + properties: + interrupt-names: + minItems: 2 + required: + - interrupt-names + dependencies: wakeup-event-action: [ wakeup-source ] linux,input-value: [ gpios ] @@ -137,6 +167,15 @@ examples: linux,code = <108>; interrupts = <1 IRQ_TYPE_EDGE_FALLING>; }; + + key-wakeup { + label = "GPIO Key WAKEUP"; + linux,code = <143>; + interrupts-extended = <&intc 2 IRQ_TYPE_EDGE_FALLING>, + <&intc_wakeup 0 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "irq", "wakeup"; + wakeup-source; + }; }; ...
Allow configuring an optional dedicated wakeirq for gpio-keys that some SoCs have. Let's use the common interrupt naming "irq" and "wakeup" that we already have in use for some drivers and subsystems like i2c framework. Note that the gpio-keys interrupt property is optional. If only a gpio property is specified, the driver tries to translate the gpio into an interrupt. Signed-off-by: Tony Lindgren <tony@atomide.com> --- Changes since v1: - Run make dt_binding_check on the binding - Add better checks for interrupt-names as suggested by Rob, it is now required if two interrupts are configured - Add more decription entries - Add a new example for key-wakeup --- .../devicetree/bindings/input/gpio-keys.yaml | 41 ++++++++++++++++++- 1 file changed, 40 insertions(+), 1 deletion(-)