| Message ID | 20231225092843.5993-2-xiazhengqiao@huaqin.corp-partner.google.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | HID: i2c-hid: elan: Add ili2901 timing | expand |
On Mon, 25 Dec 2023 17:28:42 +0800, xiazhengqiao wrote: > Because ilitek, ili2901 needs to use reset to pull down the time for 10ms, > so we need to control the reset, use this drive control. > > Signed-off-by: xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com> > --- > Documentation/devicetree/bindings/input/elan,ekth6915.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/elan,ekth6915.example.dtb: touchscreen@10: compatible: ['elan,ekth6915'] is too short from schema $id: http://devicetree.org/schemas/input/elan,ekth6915.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231225092843.5993-2-xiazhengqiao@huaqin.corp-partner.google.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 25/12/2023 10:28, xiazhengqiao wrote: > Because ilitek, ili2901 needs to use reset to pull down the time for 10ms, > so we need to control the reset, use this drive control. > > Signed-off-by: xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com> > --- > Documentation/devicetree/bindings/input/elan,ekth6915.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > index 3e2d216c6432..b9e51432b9e8 100644 > --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > @@ -20,6 +20,7 @@ properties: > compatible: > items: > - const: elan,ekth6915 > + - const: ilitek,ili2901 1. You are adding fallback which was not explained in commit msg. 2. What's more, this was not tested. Please test your code before sending... 3. Plus you did not Cc maintainers, so I suspect you work on some ancient tree... Best regards, Krzysztof
On 25/12/2023 14:38, Zhengqiao Xia wrote:
> I am so sorry, I need to download an Linux Input code.
Before sending further patches, please carefully read:
1.
https://elixir.bootlin.com/linux/v6.7-rc7/source/Documentation/process/submitting-patches.rst
2. https://subspace.kernel.org/etiquette.html
Best regards,
Krzysztof
diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml index 3e2d216c6432..b9e51432b9e8 100644 --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml @@ -20,6 +20,7 @@ properties: compatible: items: - const: elan,ekth6915 + - const: ilitek,ili2901 reg: const: 0x10
Because ilitek, ili2901 needs to use reset to pull down the time for 10ms, so we need to control the reset, use this drive control. Signed-off-by: xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com> --- Documentation/devicetree/bindings/input/elan,ekth6915.yaml | 1 + 1 file changed, 1 insertion(+)