| Message ID | 20240119074831.2979671-1-phoenixshen@google.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] Input: cros_ec_keyb: add support for base attached event | expand |
On Fri, Jan 19, 2024 at 03:48:17PM +0800, Ting Shen wrote: > There is a new type of ChromeOS detachable keyboard that talks to > the host via CrOS EC host command interface, rather than the USB > interface. > > To trigger the firmware update daemon (hammerd) on this keyboard, a > signal is required to replace the typical USB hotplug event. This patch > addresses this by mapping the EC's BASE_ATTACHED event to SW_DOCK. I think emitting an uevent on attachment might make more sense here, SW_DOCK is to signal attachment of a legacy docking station. Thanks.
diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c index 30678a34cf647..d2e0d89d4ffdf 100644 --- a/drivers/input/keyboard/cros_ec_keyb.c +++ b/drivers/input/keyboard/cros_ec_keyb.c @@ -128,6 +128,11 @@ static const struct cros_ec_bs_map cros_ec_keyb_bs[] = { .code = SW_TABLET_MODE, .bit = EC_MKBP_TABLET_MODE, }, + { + .ev_type = EV_SW, + .code = SW_DOCK, + .bit = EC_MKBP_BASE_ATTACHED, + }, }; /*
There is a new type of ChromeOS detachable keyboard that talks to the host via CrOS EC host command interface, rather than the USB interface. To trigger the firmware update daemon (hammerd) on this keyboard, a signal is required to replace the typical USB hotplug event. This patch addresses this by mapping the EC's BASE_ATTACHED event to SW_DOCK. Signed-off-by: Ting Shen <phoenixshen@google.com> --- Changes in v2: - update commit message drivers/input/keyboard/cros_ec_keyb.c | 5 +++++ 1 file changed, 5 insertions(+)