| Message ID | 20240201115320.684-2-jirislaby@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: unused struct members cleanup | expand |
Hi Jiri I got this patch tested by a user and no regression was reported. Thanks > On 01-Feb-2024, at 5:23 PM, Jiri Slaby (SUSE) <jirislaby@kernel.org> wrote: > > The backlight members in struct apple_sc_backlight are unused. They were > added in commit 9018eacbe623 (HID: apple: Add support for keyboard > backlight on certain T2 Macs.), but never used. > > As this is not a struct to communicate with the HW, remove these. > > Found by https://github.com/jirislaby/clang-struct. > > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> > Cc: Paul Pawlowski <paul@mrarm.io> > Cc: Aun-Ali Zaidi <admin@kodeit.net> > Cc: Aditya Garg <gargaditya08@live.com> > Cc: Jiri Kosina <jikos@kernel.org> > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> > --- > drivers/hid/hid-apple.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c > index b9c7c0ed7bcc..bd022e004356 100644 > --- a/drivers/hid/hid-apple.c > +++ b/drivers/hid/hid-apple.c > @@ -79,7 +79,6 @@ struct apple_non_apple_keyboard { > struct apple_sc_backlight { > struct led_classdev cdev; > struct hid_device *hdev; > - unsigned short backlight_off, backlight_on_min, backlight_on_max; > }; > > struct apple_sc { > -- > 2.43.0 >
diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c index b9c7c0ed7bcc..bd022e004356 100644 --- a/drivers/hid/hid-apple.c +++ b/drivers/hid/hid-apple.c @@ -79,7 +79,6 @@ struct apple_non_apple_keyboard { struct apple_sc_backlight { struct led_classdev cdev; struct hid_device *hdev; - unsigned short backlight_off, backlight_on_min, backlight_on_max; }; struct apple_sc {
The backlight members in struct apple_sc_backlight are unused. They were added in commit 9018eacbe623 (HID: apple: Add support for keyboard backlight on certain T2 Macs.), but never used. As this is not a struct to communicate with the HW, remove these. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> Cc: Paul Pawlowski <paul@mrarm.io> Cc: Aun-Ali Zaidi <admin@kodeit.net> Cc: Aditya Garg <gargaditya08@live.com> Cc: Jiri Kosina <jikos@kernel.org> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> --- drivers/hid/hid-apple.c | 1 - 1 file changed, 1 deletion(-)