diff mbox series

dt-bindings: input: allwinner,sun4i-a10-lrad: drop redundant type from label

Message ID 20240226122934.89257-1-krzysztof.kozlowski@linaro.org (mailing list archive)
State Mainlined
Commit b0f3f9ab419c243389da6c0dd6a9db0eea560146
Headers show
Series dt-bindings: input: allwinner,sun4i-a10-lrad: drop redundant type from label | expand

Commit Message

Krzysztof Kozlowski Feb. 26, 2024, 12:29 p.m. UTC
dtschema defines label as string, so $ref in other bindings is
redundant.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../bindings/input/allwinner,sun4i-a10-lradc-keys.yaml           | 1 -
 1 file changed, 1 deletion(-)

Comments

Jernej Škrabec Feb. 26, 2024, 5:31 p.m. UTC | #1
Dne ponedeljek, 26. februar 2024 ob 13:29:34 CET je Krzysztof Kozlowski napisal(a):
> dtschema defines label as string, so $ref in other bindings is
> redundant.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

I already send PR for 6.9. Do you mind if it waits on next cycle?

Best regards,
Jernej

> ---
>  .../bindings/input/allwinner,sun4i-a10-lradc-keys.yaml           | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml b/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
> index 5efceb313879..c384bf0bb25d 100644
> --- a/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
> +++ b/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
> @@ -49,7 +49,6 @@ patternProperties:
>      $ref: input.yaml#
>      properties:
>        label:
> -        $ref: /schemas/types.yaml#/definitions/string
>          description: Descriptive name of the key
>  
>        linux,code: true
>
Rob Herring (Arm) Feb. 27, 2024, 3:50 a.m. UTC | #2
On Mon, Feb 26, 2024 at 06:31:38PM +0100, Jernej Škrabec wrote:
> Dne ponedeljek, 26. februar 2024 ob 13:29:34 CET je Krzysztof Kozlowski napisal(a):
> > dtschema defines label as string, so $ref in other bindings is
> > redundant.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> 
> I already send PR for 6.9. Do you mind if it waits on next cycle?

This should go via input tree, not allwinner.

Acked-by: Rob Herring <robh@kernel.org>
Krzysztof Kozlowski Feb. 27, 2024, 6:48 a.m. UTC | #3
On 26/02/2024 18:31, Jernej Škrabec wrote:
> Dne ponedeljek, 26. februar 2024 ob 13:29:34 CET je Krzysztof Kozlowski napisal(a):
>> dtschema defines label as string, so $ref in other bindings is
>> redundant.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> 
> I already send PR for 6.9. Do you mind if it waits on next cycle?

Yes.

Best regards,
Krzysztof
Krzysztof Kozlowski Feb. 27, 2024, 6:49 a.m. UTC | #4
On 27/02/2024 07:48, Krzysztof Kozlowski wrote:
> On 26/02/2024 18:31, Jernej Škrabec wrote:
>> Dne ponedeljek, 26. februar 2024 ob 13:29:34 CET je Krzysztof Kozlowski napisal(a):
>>> dtschema defines label as string, so $ref in other bindings is
>>> redundant.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
>>
>> I already send PR for 6.9. Do you mind if it waits on next cycle?
> 
> Yes.

Damn English. I don't mind, but as Rob pointed this is patch for input.

Best regards,
Krzysztof
Dmitry Torokhov March 5, 2024, 5:51 p.m. UTC | #5
On Mon, Feb 26, 2024 at 01:29:34PM +0100, Krzysztof Kozlowski wrote:
> dtschema defines label as string, so $ref in other bindings is
> redundant.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Applied, thank you.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml b/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
index 5efceb313879..c384bf0bb25d 100644
--- a/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
+++ b/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
@@ -49,7 +49,6 @@  patternProperties:
     $ref: input.yaml#
     properties:
       label:
-        $ref: /schemas/types.yaml#/definitions/string
         description: Descriptive name of the key
 
       linux,code: true