Message ID | 20240228113914.3864232-1-Basavaraj.Natikar@amd.com (mailing list archive) |
---|---|
State | New |
Delegated to: | Jiri Kosina |
Headers | show |
Series | [hid-next] HID: amd_sfh: Set the AMD SFH driver to depend on x86 | expand |
On Wed, 28 Feb 2024, Basavaraj Natikar wrote: > Considering that amd_sfh exists only on AMD platforms, set the AMD SFH > driver to depend on x86 to avoid build warnings or errors on other > architectures, as shown below. > > drivers/hid/amd-sfh-hid/amd_sfh_pcie.c: In function 'amd_mp2_pci_probe': > drivers/hid/amd-sfh-hid/amd_sfh_pcie.c:413:21: error: 'boot_cpu_data' > undeclared (first use in this function); did you mean 'boot_cpu_hwid'? > 413 | if (boot_cpu_data.x86 >= 0x1A) > | ^~~~~~~~~~~~~ > | boot_cpu_hwid > > Fixes: 6296562f30b1 ("HID: amd_sfh: Extend MP2 register access to SFH") > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Closes: https://lore.kernel.org/all/20240228145648.41c493ec@canb.auug.org.au/ > Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com> Applied, thanks.
diff --git a/drivers/hid/amd-sfh-hid/Kconfig b/drivers/hid/amd-sfh-hid/Kconfig index af752dd3a340..329de5e12c1a 100644 --- a/drivers/hid/amd-sfh-hid/Kconfig +++ b/drivers/hid/amd-sfh-hid/Kconfig @@ -6,6 +6,7 @@ menu "AMD SFH HID Support" config AMD_SFH_HID tristate "AMD Sensor Fusion Hub" depends on HID + depends on X86 help If you say yes to this option, support will be included for the AMD Sensor Fusion Hub.
Considering that amd_sfh exists only on AMD platforms, set the AMD SFH driver to depend on x86 to avoid build warnings or errors on other architectures, as shown below. drivers/hid/amd-sfh-hid/amd_sfh_pcie.c: In function 'amd_mp2_pci_probe': drivers/hid/amd-sfh-hid/amd_sfh_pcie.c:413:21: error: 'boot_cpu_data' undeclared (first use in this function); did you mean 'boot_cpu_hwid'? 413 | if (boot_cpu_data.x86 >= 0x1A) | ^~~~~~~~~~~~~ | boot_cpu_hwid Fixes: 6296562f30b1 ("HID: amd_sfh: Extend MP2 register access to SFH") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Closes: https://lore.kernel.org/all/20240228145648.41c493ec@canb.auug.org.au/ Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com> --- drivers/hid/amd-sfh-hid/Kconfig | 1 + 1 file changed, 1 insertion(+)