diff mbox series

[v2,1/1] HID: uclogic: Expose firmware name

Message ID 20240322100210.107152-2-jose.exposito89@gmail.com (mailing list archive)
State Mainlined
Commit a721b1423b049323d0987700ff125b46208046f9
Delegated to: Jiri Kosina
Headers show
Series Expose firmware name to identify tablets in libwacom | expand

Commit Message

José Expósito March 22, 2024, 9:59 a.m. UTC
Some vendors reuse the same product ID for different tablets, making it
difficult for userspace to figure out which table is connected.
While matching the device name has been used in the past by userspace to
workaround this limitation, some devices have shown that this is not
always a valid approach [1].

However, if userspace could access the firmware version name, it would
be possible to know which tablet is actually connected by matching it
against a list of known firmware names [2].

This patch exposes the firmware version name in the hid->uniq field.

Link: https://github.com/linuxwacom/libwacom/issues/609  [1]
Link: https://github.com/linuxwacom/libwacom/issues/610  [2]
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
---
 drivers/hid/hid-uclogic-params.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Jiri Kosina April 3, 2024, 11:51 a.m. UTC | #1
On Fri, 22 Mar 2024, José Expósito wrote:

> Some vendors reuse the same product ID for different tablets, making it
> difficult for userspace to figure out which table is connected.
> While matching the device name has been used in the past by userspace to
> workaround this limitation, some devices have shown that this is not
> always a valid approach [1].
> 
> However, if userspace could access the firmware version name, it would
> be possible to know which tablet is actually connected by matching it
> against a list of known firmware names [2].
> 
> This patch exposes the firmware version name in the hid->uniq field.
> 
> Link: https://github.com/linuxwacom/libwacom/issues/609  [1]
> Link: https://github.com/linuxwacom/libwacom/issues/610  [2]
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/hid/hid-uclogic-params.c b/drivers/hid/hid-uclogic-params.c
index 9859dad36495..5bab006ec165 100644
--- a/drivers/hid/hid-uclogic-params.c
+++ b/drivers/hid/hid-uclogic-params.c
@@ -884,6 +884,9 @@  static int uclogic_params_huion_init(struct uclogic_params *params,
 		goto cleanup;
 	}
 
+	/* The firmware is used in userspace as unique identifier */
+	strscpy(hdev->uniq, ver_ptr, sizeof(hdev->uniq));
+
 	/* If this is a transition firmware */
 	if (strcmp(ver_ptr, transition_ver) == 0) {
 		hid_dbg(hdev,