| Message ID | 20240403150638.18749-1-Yaroslav.Furman@softeq.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | [v2] HID: logitech-dj: allow mice to report multimedia keycodes | expand |
Hi Yaroslav, On 4/3/24 5:06 PM, Yaroslav Furman wrote: > From: Yaraslau Furman <yaro330@gmail.com> > > So, I think this should work fine for now, but IMO we should see if it's > possible to allow the driver to receive all events that a keyboard can send, > since Windows application can assign pretty much any keycode to any mouse > button (perhaps not the main ones though), and then we might see the same situation again. > > I tried doing that on my system but the driver stopped working completely. The actual code change itself looks fine, but the above should have gone into a cover-letter or something like that. This is not a proper commit message and this is also lacking your Signed-off-by (which you did correctly include in your original version: https://lore.kernel.org/linux-input/20240128214906.60606-1-yaro330@gmail.com/ Please send a v3 with a proper commit-msg + Signed-off-by. Regards, Hans > --- > drivers/hid/hid-logitech-dj.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c > index e6a8b6d8eab7..3c3c497b6b91 100644 > --- a/drivers/hid/hid-logitech-dj.c > +++ b/drivers/hid/hid-logitech-dj.c > @@ -965,9 +965,7 @@ static void logi_hidpp_dev_conn_notif_equad(struct hid_device *hdev, > } > break; > case REPORT_TYPE_MOUSE: > - workitem->reports_supported |= STD_MOUSE | HIDPP; > - if (djrcv_dev->type == recvr_type_mouse_only) > - workitem->reports_supported |= MULTIMEDIA; > + workitem->reports_supported |= STD_MOUSE | HIDPP | MULTIMEDIA; > break; > } > }
diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c index e6a8b6d8eab7..3c3c497b6b91 100644 --- a/drivers/hid/hid-logitech-dj.c +++ b/drivers/hid/hid-logitech-dj.c @@ -965,9 +965,7 @@ static void logi_hidpp_dev_conn_notif_equad(struct hid_device *hdev, } break; case REPORT_TYPE_MOUSE: - workitem->reports_supported |= STD_MOUSE | HIDPP; - if (djrcv_dev->type == recvr_type_mouse_only) - workitem->reports_supported |= MULTIMEDIA; + workitem->reports_supported |= STD_MOUSE | HIDPP | MULTIMEDIA; break; } }
From: Yaraslau Furman <yaro330@gmail.com> So, I think this should work fine for now, but IMO we should see if it's possible to allow the driver to receive all events that a keyboard can send, since Windows application can assign pretty much any keycode to any mouse button (perhaps not the main ones though), and then we might see the same situation again. I tried doing that on my system but the driver stopped working completely. --- drivers/hid/hid-logitech-dj.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)