diff mbox series

HID: nintendo: Remove unused function

Message ID 20240407021100.48008-1-jiapeng.chong@linux.alibaba.com (mailing list archive)
State New
Delegated to: Jiri Kosina
Headers show
Series HID: nintendo: Remove unused function | expand

Commit Message

Jiapeng Chong April 7, 2024, 2:11 a.m. UTC
The function are defined in the hid-nintendo.c file, but not called
elsewhere, so delete the unused function.

drivers/hid/hid-nintendo.c:697:20: warning: unused function 'joycon_device_has_usb'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8704
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/hid/hid-nintendo.c | 9 ---------
 1 file changed, 9 deletions(-)

Comments

Jiri Kosina April 12, 2024, 11:40 a.m. UTC | #1
On Sun, 7 Apr 2024, Jiapeng Chong wrote:

> The function are defined in the hid-nintendo.c file, but not called
> elsewhere, so delete the unused function.
> 
> drivers/hid/hid-nintendo.c:697:20: warning: unused function 'joycon_device_has_usb'.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8704
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c
index 4b4ca990f968..b4a97803eca3 100644
--- a/drivers/hid/hid-nintendo.c
+++ b/drivers/hid/hid-nintendo.c
@@ -694,15 +694,6 @@  static inline bool joycon_device_is_n64con(struct joycon_ctlr *ctlr)
 	return ctlr->hdev->product == USB_DEVICE_ID_NINTENDO_N64CON;
 }
 
-static inline bool joycon_device_has_usb(struct joycon_ctlr *ctlr)
-{
-	return joycon_device_is_procon(ctlr) ||
-	       joycon_device_is_chrggrip(ctlr) ||
-	       joycon_device_is_snescon(ctlr) ||
-	       joycon_device_is_gencon(ctlr) ||
-	       joycon_device_is_n64con(ctlr);
-}
-
 /*
  * Controller type helpers
  *