| Message ID | 20240502075534.882628-9-christoph.fritz@hexdev.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | LIN Bus support for Linux | expand |
On 02/05/2024 09:55, Christoph Fritz wrote: > A LIN bus supports up to 64 identifiers in one byte. This commit adds a > special frame ID, beyond the actual LIN identifiers, for signaling RX > offload configuration requests. This ID will be utilized in future LIN > enhancements to the CAN broadcast manager. > > Signed-off-by: Christoph Fritz <christoph.fritz@hexdev.de> > --- > include/net/lin.h | 1 + You just added this file in other patch. What is the point of splitting line-per-line additions? There is no user of this in this patch. Squash it with the patch adding the file. Best regards, Krzysztof
On Thu, 2024-05-02 at 12:27 +0200, Krzysztof Kozlowski wrote: > On 02/05/2024 09:55, Christoph Fritz wrote: > > A LIN bus supports up to 64 identifiers in one byte. This commit adds a > > special frame ID, beyond the actual LIN identifiers, for signaling RX > > offload configuration requests. This ID will be utilized in future LIN > > enhancements to the CAN broadcast manager. > > > > Signed-off-by: Christoph Fritz <christoph.fritz@hexdev.de> > > --- > > include/net/lin.h | 1 + > > You just added this file in other patch. What is the point of splitting > line-per-line additions? My intention was to make the review process easier by separating the BCM (Broadcast Manager) logic from the basic driver implementation. > There is no user of this in this patch. Squash it with the patch adding > the file. OK v3 is coming up Thanks -- Christoph
diff --git a/include/net/lin.h b/include/net/lin.h index 944e775c40e79..e7c7c820a6e18 100644 --- a/include/net/lin.h +++ b/include/net/lin.h @@ -19,6 +19,7 @@ #define LIN_ID_MASK GENMASK(5, 0) /* special ID descriptions for LIN */ +#define LIN_RXOFFLOAD_DATA_FLAG 0x00000200U #define LIN_ENHANCED_CKSUM_FLAG 0x00000100U extern u8 lin_get_id_parity(u8 id);
A LIN bus supports up to 64 identifiers in one byte. This commit adds a special frame ID, beyond the actual LIN identifiers, for signaling RX offload configuration requests. This ID will be utilized in future LIN enhancements to the CAN broadcast manager. Signed-off-by: Christoph Fritz <christoph.fritz@hexdev.de> --- include/net/lin.h | 1 + 1 file changed, 1 insertion(+)