| Message ID | 20240511121245.109644-2-felix@kaechele.ca (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | input: himax_hx83112b: add support for HX83100A | expand |
On Sat, May 11, 2024 at 08:12:22AM -0400, Felix Kaechele wrote: > Add a compatible string for the Himax HX83100A touch controller. > > Signed-off-by: Felix Kaechele <felix@kaechele.ca> Commit message should mention what makes this device incompatible with the existing device. Thanks, Conor. > --- > .../devicetree/bindings/input/touchscreen/himax,hx83112b.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml > index f42b23d532eb..f5cfacb5e966 100644 > --- a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml > +++ b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml > @@ -15,6 +15,7 @@ allOf: > properties: > compatible: > enum: > + - himax,hx83100a > - himax,hx83112b > > reg: > -- > 2.45.0 >
On 2024-05-11 08:38, Conor Dooley wrote: > On Sat, May 11, 2024 at 08:12:22AM -0400, Felix Kaechele wrote: >> Add a compatible string for the Himax HX83100A touch controller. >> >> Signed-off-by: Felix Kaechele <felix@kaechele.ca> > > Commit message should mention what makes this device incompatible with > the existing device. Thanks! I have added this note in the commit message which will be part of a v3, coming after I hopefully receive a few more comments on the other parts of this change: The HX83100A presents touch events on its internal bus rather than offering a dedicated event register like the other chips in this family do. Felix
On Sat, May 11, 2024 at 10:10:08AM -0400, Felix Kaechele wrote: > On 2024-05-11 08:38, Conor Dooley wrote: > > On Sat, May 11, 2024 at 08:12:22AM -0400, Felix Kaechele wrote: > > > Add a compatible string for the Himax HX83100A touch controller. > > > > > > Signed-off-by: Felix Kaechele <felix@kaechele.ca> > > > > Commit message should mention what makes this device incompatible with > > the existing device. > > Thanks! > > I have added this note in the commit message which will be part of a v3, > coming after I hopefully receive a few more comments on the other parts of > this change: > > The HX83100A presents touch events on its internal bus rather than offering > a dedicated event register like the other chips in this family do. Ye, that sounds good. W/ that, Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
diff --git a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml index f42b23d532eb..f5cfacb5e966 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml @@ -15,6 +15,7 @@ allOf: properties: compatible: enum: + - himax,hx83100a - himax,hx83112b reg:
Add a compatible string for the Himax HX83100A touch controller. Signed-off-by: Felix Kaechele <felix@kaechele.ca> --- .../devicetree/bindings/input/touchscreen/himax,hx83112b.yaml | 1 + 1 file changed, 1 insertion(+)