diff mbox series

[1/2] dt-bindings: input: touchscreen: add Hynitron CST816X

Message ID 20240813-b4-cst816s-b4-v1-1-78a03cbef328@gmail.com (mailing list archive)
State New
Headers show
Series Code quality enhancing and add tag for dt-bindings | expand

Commit Message

Oleh Kuzhylnyi Aug. 12, 2024, 11:22 p.m. UTC 
Add documentation for the Hynitron CST816X touchscreen bindings.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Oleh Kuzhylnyi <kuzhylol@gmail.com>
---
 .../input/touchscreen/hynitron,cst816s.yaml        | 57 ++++++++++++++++++++++
 1 file changed, 57 insertions(+)

Comments

Krzysztof Kozlowski Aug. 13, 2024, 9:15 a.m. UTC | #1 
On 13/08/2024 01:22, Oleh Kuzhylnyi wrote:
> Add documentation for the Hynitron CST816X touchscreen bindings.
> 
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

How this could come with review tag if this is v1? Or is it not
correctly versioned?

That will confuse all the tools...

git format-patch -v2 or just use b4.


> Signed-off-by: Oleh Kuzhylnyi <kuzhylol@gmail.com>

...

> +
> +properties:
> +  compatible:
> +    enum:
> +      - hynitron,cst816s
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reset-gpios:
> +    maxItems: 1
> +
> +additionalProperties: false

If there is going to be new version, this goes after required: block.


Best regards,
Krzysztof
Oleh Kuzhylnyi Aug. 16, 2024, 5:54 p.m. UTC | #2 
On Tue, Aug 13, 2024 at 11:15 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 13/08/2024 01:22, Oleh Kuzhylnyi wrote:
> > Add documentation for the Hynitron CST816X touchscreen bindings.
> >
> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> How this could come with review tag if this is v1? Or is it not
> correctly versioned?
>
> That will confuse all the tools...
>
> git format-patch -v2 or just use b4.

Oops. Messed up with b4 configuration. I will resend the proper version.

> > Signed-off-by: Oleh Kuzhylnyi <kuzhylol@gmail.com>
>
> ...
>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - hynitron,cst816s
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  reset-gpios:
> > +    maxItems: 1
> > +
> > +additionalProperties: false
>
> If there is going to be new version, this goes after required: block.
>
>
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816s.yaml b/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816s.yaml
new file mode 100644
index 000000000000..ac9f1d8e8fc0
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/touchscreen/hynitron,cst816s.yaml
@@ -0,0 +1,57 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/touchscreen/hynitron,cst816s.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Hynitron CST816S Touchscreen controller
+
+description:
+  Hynitron CST816S Touchscreen controller for 1.28-inch 240x240 Resolution
+  Touch LCD Display Module
+
+maintainers:
+  - Oleh Kuzhylnyi <kuzhylol@gmail.com>
+
+allOf:
+  - $ref: touchscreen.yaml#
+
+properties:
+  compatible:
+    enum:
+      - hynitron,cst816s
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  reset-gpios:
+    maxItems: 1
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - reset-gpios
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+      touchscreen@15 {
+        compatible = "hynitron,cst816s";
+        reg = <0x15>;
+        interrupt-parent = <&gpio0>;
+        interrupts = <4 IRQ_TYPE_EDGE_RISING>;
+        reset-gpios = <&gpio 17 GPIO_ACTIVE_LOW>;
+      };
+    };
+
+...