Message ID | 20241010-input_automate_of_node_put-v1-10-ebc62138fbf8@gmail.com (mailing list archive) |
---|---|
State | Superseded |
Commit | 00850d7b542aa4a8240cf977d43dc6d2158e48d7 |
Headers | show |
Series | input: automate of_node_put() calls for device_node | expand |
On Thu, Oct 10, 2024 at 11:26:00PM +0200, Javier Carrasco wrote: > Use the '__free(device_node)' macro to automatically free the device > node, removing the need for explicit calls to 'of_node_put()' to > decrement its refcount. > > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> Applied, thank you.
diff --git a/drivers/input/touchscreen/ts4800-ts.c b/drivers/input/touchscreen/ts4800-ts.c index 6cf66aadc10e..98422d1e80d6 100644 --- a/drivers/input/touchscreen/ts4800-ts.c +++ b/drivers/input/touchscreen/ts4800-ts.c @@ -110,18 +110,17 @@ static int ts4800_parse_dt(struct platform_device *pdev, { struct device *dev = &pdev->dev; struct device_node *np = dev->of_node; - struct device_node *syscon_np; u32 reg, bit; int error; - syscon_np = of_parse_phandle(np, "syscon", 0); + struct device_node *syscon_np __free(device_node) = + of_parse_phandle(np, "syscon", 0); if (!syscon_np) { dev_err(dev, "no syscon property\n"); return -ENODEV; } ts->regmap = syscon_node_to_regmap(syscon_np); - of_node_put(syscon_np); if (IS_ERR(ts->regmap)) { dev_err(dev, "cannot get parent's regmap\n"); return PTR_ERR(ts->regmap);
Use the '__free(device_node)' macro to automatically free the device node, removing the need for explicit calls to 'of_node_put()' to decrement its refcount. Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> --- drivers/input/touchscreen/ts4800-ts.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)