From patchwork Wed Feb 5 00:45:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13960271 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2043.outbound.protection.outlook.com [40.107.249.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DA50228375; Wed, 5 Feb 2025 00:46:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716370; cv=fail; b=i34yTaCM2dxuNyHCCPalT1PnVTUGdqseEG6Sb+pK39x7oYDwGB3iBjFpu+vhz+IvdVHKBX6VlPMa8ZLIwNWApPOcTMlfIDo2VWdCdIYimewZvNF9y69T3g5a4EqNBZH8iUyiNZOpoyJJcACWxWF4cJ7og/OP0Rz4HoyhRedcOnU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716370; c=relaxed/simple; bh=DNmSM/zlaiHe7y+SpoUtP9k7yyKM9LouOCBuhZSkcWM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=WIVfNp75u+L2jQiDhml2tqmJPmTJTHZbrWSo8e7fEsRF7El+UmelFIEm0G6qPTdsR3ow+5DBsoSjjzSiUlj9rA3CWR29QfEB+aAPcmMRlu7ZzIg4M84R5kdVEY96d2t0TBX4Ejq1RkfQBS++5S6Bme5CyrWcsg62Ku6/vn2703I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=KLPD0tet; arc=fail smtp.client-ip=40.107.249.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="KLPD0tet" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gVTEEGNvXF3weDr/u+3fSYMi9f/zMXGF/kjwJs0bnev7HG7nHnDVWbIuRggWj3Mc0aIWPZuDGrF/Te3JPuS8dlCVg4qy7rCxhHZshsIxQcPnAQJwJ1tq6XMxLEOkMdOKwk1/7+3axbT1Vjl7ZER8STZeJvXYQrEdert3Dhija6wsD+rsAMJllv0fwI2rqrIXXxWQy3OClPi48tvC1fE0L5JN9eI6FJ93NCNFnSRVdr7PqKylIMgiWErwgpPUA6LFAMLoIe+TpsLDXb0ZC2c+A1/wx1BQNZ+/12vDjIbeJmJ6vs/1MGaEX8SXxlMlGi+nI8XaeeWIuon/AMQQTrTRWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cS+DM8g/1DZ++lGRTiLrP/ykpiHku6xeI0up7+EwB9k=; b=uEg9El4vtReCGxZ2C/l8vlw5wUtnyLJJllGLQMxjfO9+MLaebusvm7O45D3sQfsZuzFZytjIKjHBXlTKJHzORed6gM+/MHz0f2hcqYeJQn4hElW9+7IdqAaTV3l+zFSYwonKO3rca3ShMIGVvL94EX4KkikFNqzgg8bCeVWWPRxNzw2wC+YCo2ddbp4TUOe6LH8TekO4pnawbAIuf6xWTy2Pv/fKO02c3NPgOtZsUuQoPCSWe2dkcPAHrKznmGCaoOixOTNWHiHbvXBLfBukISAK/SwKiqKXQ0JQI6nzCSthAjx8UitXSuwgylRCD3c9M9Zr3L0x6ADw6Y6/Mm2PWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cS+DM8g/1DZ++lGRTiLrP/ykpiHku6xeI0up7+EwB9k=; b=KLPD0tetSmCYuHWkpXKWL/XiL7E2aKZYDsywG1RR0R5gEjm7jMmnrnSXQEFPDzb6TJmgozE7Tkz0uiAOOaZ8Q3d2seTJbU3h14V+FdW0hyademstOxu0oBEu4J3H9PIAup72lL87Q175SvlsCfuk8aL1e1vOUNPiAMIjoJGtBx8j5839V/+WqZovsWbOlGS8nQGDZJBJDa1ohJtk369HGDIkjnZsWv4fIovmlbPfkbHklH7d9uXT6oWrgWqqxmKOR9hnsJW8+f9ygTK9AYyGLW/ifV4OdG1Fa2Cplv0pNx+Srs1IfOz8hvsDExyzYoR6FJesnvnAA24YKCAKGCswFQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB9PR04MB8250.eurprd04.prod.outlook.com (2603:10a6:10:245::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.25; Wed, 5 Feb 2025 00:46:01 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:46:01 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:45:15 +0800 Subject: [PATCH 2/4] input: keyboard: omap4_keypad: Use devm_pm_set_wake_irq Message-Id: <20250205-input-cleanup-v1-2-9758898ff8cb@nxp.com> References: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> In-Reply-To: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738716321; l=1365; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=IYFb5BcVnaCb3uUN830r92UAprUHpPfeHJSpQKDJq+A=; b=FfkYBrhoOBQaCtvD5SyQDwaRuLemJLrepWna3F/0nCmeMU9mbPq96bTN33pKCeGNsqqeEMzDF fyuOAEcGZDCCyq69PqXu4/di7aztPtnrUpRibv+9witGdOSQmQBRn33 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0046.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB9PR04MB8250:EE_ X-MS-Office365-Filtering-Correlation-Id: 1fc5f90e-cb6e-44a7-ebc9-08dd457e76b3 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?J+7V/f7SqbNBKMOF3nEZrDKjlE8Tv3i?= =?utf-8?q?WcsnUfcPXrKdRhtfCot+fMKayqb+PJ9Bd59YFBv0syPSHRNqVx92Aa+wuN0BNmCsL?= =?utf-8?q?D+LoWzrQYGVimaRt2W35YUykIt3lSVEePbrVDEFLG6EOD/nSGtlZShdpdTBytJhO1?= =?utf-8?q?b0Z5AJWmDj6gqizUyydJd7eDbvzczQs/tR8p1tX8Clg7e+k0hV0bZ57izWiergLHw?= =?utf-8?q?Vq3Hoby8O70GRP8m85OvUAXLrARAdIqX+716yERMduwT+3hZjFVtmd+G6Un1INV9V?= =?utf-8?q?ZqAYg4GBF2rrmO2klDVkP0Bj4UUo6OFnvDL3C7yq2Fm1/IpJMIIRMirT0BY5pB/09?= =?utf-8?q?OSgu0W5I1R7B2Ho/uoOUkoFmkDl+e+9zO2DEq43qy8yUSQKSEl/aBhHa/i0lvhEGd?= =?utf-8?q?BtOvvFaKzzNBQYGxQfFz1moSeu2SAgKcWrWY58UoV/Artn0amSLZQNenCEn45q3zR?= =?utf-8?q?rTOkt5AzRh8GwyfRJB9MQuT0Njbiz+KdY/o2ZKH3MmxCQfqcZp9TQAJ3lsp56QYBs?= =?utf-8?q?v9OKSmB9AGgcyI4+jlqmkKefK0UoY3ZjTBWi042E6NEtwI14lmYiwYOy2qh48bb3q?= =?utf-8?q?06gu5DtOMN/K00yvCGhfM1Ou3cY5/JMma0E78ZxgY5Xsm+A087n33ZnwwLNZVWpe/?= =?utf-8?q?xRPl0O/LSvlbxIJoWepU+6GHY7XKUkKN9fPZq5ylcYP8fyJdWzZ8pSAJYYM1+LyYn?= =?utf-8?q?E/Hmp6CyW4cex83pIB3HLoknJeCCT5YCP2/azfiKqi+BJgeaTyl3JPiOHI0QKOPCN?= =?utf-8?q?dAY46UmG4CHGXaM1APOEWKLzicxDuoInFjfT2F6PcDPJ/SJ4LBx6s8RHW9HZ86/2+?= =?utf-8?q?ly8o01/7Vgoj2g4laB8vsz4JkBBEkUvupej3EPgzSc6dwHwMz/GSafHv0vw7QLUu9?= =?utf-8?q?BxLCiU9ReHEAOsC2Ol02un3c2oCAfDySAREvAUtPb8XpHQmwr5kKuEV8WGb2N/1wi?= =?utf-8?q?LzQ/7ASOz9x05gldrieBWsAddJYSqiKtyRBGoj3zLv7RxqPLtooLaUpBLbWFoB6WK?= =?utf-8?q?uZrVuZ1XmYXxBOQWTQInfHmFIyOi8BL75xVxNI9G06BaNBZbgwXl6t0dgX3OsSPb1?= =?utf-8?q?uMqrOkxYteRuggDWWgiuc6RT4MYx1psEDevNVgB7THazaCNrz2tWkjoJ1yM1XvmOj?= =?utf-8?q?Abe1X+/IveqsSVVcMyd3rAj2FcM4ltM05tOQPUh4sQGhbiY70k1B3B1/UJG1y6W7A?= =?utf-8?q?NBK2UPDf7BDpapm0x0Au4unxNifzAaDHuXJuiAVgqCG6r82ezua7J4K3+7+NKC8sc?= =?utf-8?q?W6kEL9x70j5hBQELcMt9+TpG34TlqGjdSxmdEbSqEF/MgKcY/pLjvQKNuZl4U6B9i?= =?utf-8?q?LUrFolr5+MlowTENeSds0NBBzgZE83X9e0lQ+O9Lj7jq/3RSVTs9Y0E=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ocgQEKJHU6OSMDS/qS+rz+txPuyg?= =?utf-8?q?U853e9wFUUSZAFRy6n47D7s+PZHHciONQw2jBZgok/8Z1X466yPp9OiJaBlXtjLon?= =?utf-8?q?THZEyaCK4i5sr1vPwe5iybiHhEgbGcxHU++8FWtsm+Blivwyt8sijPDXXpWhfzCFU?= =?utf-8?q?XujuWAtle5VB1ZYFYEQtVIlOWVBN426yR21Py78tj59nHrtKLayLCwOcBpsb2Hium?= =?utf-8?q?nQoPD22Mfevb9T/QnbJ0rulGYiougtrgsiLSnYtebJg/V4jwh0f7RM1cPckoMBdom?= =?utf-8?q?Sq+g3JCwiD8mHQviug/xhVLRNHLnvnefMgg+gWVLrDygxC1GWS6q0Hk9W923WEX5p?= =?utf-8?q?7t4CM8C5SlmYUuiYoeKGTTbW5glwLTTxOf23JYvbb0qTLxN0D5/dGJxEKh8Oz/XJR?= =?utf-8?q?36FKMzPLZdNDYwiG9VWX+r0Ospd2AA0C1ngqj4kBbyAbnWoTZ36q+cIv6hRFbhxXA?= =?utf-8?q?09HflxH8A3EhBdGWX+Ehk3Qp/pZfaMcEbYMequKm5BQ0ZzAG6NXK0E8edn3DAmkSW?= =?utf-8?q?BWlX61ouk6aI0DKmHSvH2mWbgE0MWL6zxT6ZyBVpiua1/lGbv5sfKibbfA/emlSIM?= =?utf-8?q?tkpJcaabhgxAhWCHvEwVltqOWvCYcTK6jHM3486rZ/n7tN5SBSCT85WYajv/mcelh?= =?utf-8?q?QNqIhwv8+0T7ZAlEyQNCes/6p1SZkmb95qj6SaLroWn5OiYEyAdXlq25XWYg9nBk8?= =?utf-8?q?r3enzaj3Cd0SQak93PLPZPSRwJ2DiLydKqkJpvSiGIpdVfujq6bM1rjcvpf3uPuzM?= =?utf-8?q?fhxl73bNyc6d6nxpg2aJcUJIDki5DK17bswWh4iIjtv7MP1k3DLfKHPQP7+GSpzbv?= =?utf-8?q?dhT0Q/+Xp2tskAh+KD9dhpjegIeVPtw4W9bYSmm5t14SziGhP/eKdEx3gYz1/0j3V?= =?utf-8?q?8tBMg1Oeq+PjY7W1pT9e60+Ypd7nSYQ4pWcJZDtyKhnZYmo/FYE+UKqAaydfUZEkd?= =?utf-8?q?0fvQ30Zm14iLO20LEqpLWbvpDmzAiEt+vd80GAxJ/HPeOH3O2D+EJEVUIjh9rHfv8?= =?utf-8?q?Sq2MzB5C0dr1kg5H92IX9j3bnrbkGVmf1CuKrp1yrepZFgcA64OZ1HMspwMGFSWX5?= =?utf-8?q?1i13o+8y8EfXz9C3Y92WfcZXEMDUkWn4cHRxVQeB3bPEnr7acB4Lrd/A1DRuAbtjH?= =?utf-8?q?PtiArfLLq+YP+o90xDVlf5F4iQtn7QiKdHyFu/YMArKz9X/SmLcUBzUUowqVqbwCr?= =?utf-8?q?2u73EfNmlcONGpx26C8NvX2SK+HSeqjsXoRB5t0lVJAklcc7oy6UI0d9t85M3ub6o?= =?utf-8?q?0LZPZ2CgU8U0L2ny1tPM1SvV9cbHEG5OQRj88H5gZYnbPDiO7LGhgtwHuYHcF1Jvt?= =?utf-8?q?Gh5fDvf0lYlAlOq6d326jb8Q7To0xOc97Snewo5o7CRFCKQTyBiK9pYCNeNeCQNom?= =?utf-8?q?SrTvTLcxlKeGIMsqnIoVjWkb+lLrMFKpUW8wZCB6OWUaSPW/NTwdljh+5zIdtor8q?= =?utf-8?q?7GCNN8r/xrR5SrxiYWQum7YA8FgFYOFOKMakzG1Npaw+9YEysKlPJ4KXlMihulMcd?= =?utf-8?q?CaaNX3NkyycK?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fc5f90e-cb6e-44a7-ebc9-08dd457e76b3 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:46:01.8567 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PQ6HVuj0Tl1Dq8CWznKXPz2yBYYCKcUzAa2dLggL9PApg8DxlrLY8NMIsCFYiyX9Sk2c6VEpDMEvQm9qFBbAKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8250 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/input/keyboard/omap4-keypad.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c index bffe89c0717adf9ebe5b33892efa4dc30b158f83..b7bd649d1628a6bf10db4135f73778f62db92647 100644 --- a/drivers/input/keyboard/omap4-keypad.c +++ b/drivers/input/keyboard/omap4-keypad.c @@ -465,18 +465,13 @@ static int omap4_keypad_probe(struct platform_device *pdev) } device_init_wakeup(dev, true); - error = dev_pm_set_wake_irq(dev, keypad_data->irq); + error = devm_pm_set_wake_irq(dev, keypad_data->irq); if (error) dev_warn(dev, "failed to set up wakeup irq: %d\n", error); return 0; } -static void omap4_keypad_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); -} - static const struct of_device_id omap_keypad_dt_match[] = { { .compatible = "ti,omap4-keypad" }, {}, @@ -485,7 +480,6 @@ MODULE_DEVICE_TABLE(of, omap_keypad_dt_match); static struct platform_driver omap4_keypad_driver = { .probe = omap4_keypad_probe, - .remove = omap4_keypad_remove, .driver = { .name = "omap4-keypad", .of_match_table = omap_keypad_dt_match,