From patchwork Wed Mar 12 07:29:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Ni X-Patchwork-Id: 14013027 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8064E44C7C; Wed, 12 Mar 2025 07:30:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741764630; cv=none; b=rCoNtTvu8Um2yv6dsQye5HFiynjlTvdDMqhP5IxSed68hv9x7QzXV2yLArJKM0iMGUrX5ltU3Cf6wJ5qogFRUtphQev/bemiV+iWNx5hqR48KC2CCTFaDhd1+qXSRbIyoHyd1POv2uw3Urrf8lpRvtJhYVLLydYuZADZy7z2yus= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741764630; c=relaxed/simple; bh=C7+kXOfAnAi2hiBYO/4ZGQbS90UPNCQ5WsYRnA5PCdo=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=EUZj6WEQaNRjMaWVMxBv4QAUt/Dns4a6LbBtjtMtOelfB2xCSDg8NCPEIOJdmGMzLv0mUGaJG4O5mQIdyJUNUT4Td/pxL3ov2ZXVStVQnVrk9bR8kD8+ksN7p6Yr1akNT7syKbFc9VKW9eNeG1210GS0t9R1rLQLWK6PEpnbzLA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost (unknown [124.16.138.129]) by APP-01 (Coremail) with SMTP id qwCowADX39MQONFnQ8N8FA--.4329S2; Wed, 12 Mar 2025 15:30:24 +0800 (CST) From: Chen Ni To: jogletre@opensource.cirrus.com, fred.treven@cirrus.com, ben.bright@cirrus.com, dmitry.torokhov@gmail.com, patches@opensource.cirrus.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Chen Ni Subject: [PATCH] Input: cs40l50 - Remove redundant 'flush_workqueue()' calls Date: Wed, 12 Mar 2025 15:29:40 +0800 Message-Id: <20250312072940.1429931-1-nichen@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CM-TRANSID: qwCowADX39MQONFnQ8N8FA--.4329S2 X-Coremail-Antispam: 1UD129KBjvdXoWrKF1xZFy7tr1DuryrtFyxZrb_yoW3KFc_uF W3Kws7KrWUK3yjkFyqqr13XFyvk3Wqvay8ZFsxKr98G3409ws8Z34IvF40v3yDX34DKFnr u34qga4avrnrGjkaLaAFLSUrUUUU1b8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb-8FF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2kKe7AKxVWUXVWUAwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAq x4xG6I80ewAv7VC0I7IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Gr1j6F4UJwAm72 CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7 MxkF7I0En4kS14v26r1q6r43MxkIecxEwVAFwVW8CwCF04k20xvY0x0EwIxGrwCFx2IqxV CFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r10 6r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxV WUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG 6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr 1UYxBIdaVFxhVjvjDU0xZFpf9x0JUkUUUUUUUU= X-CM-SenderInfo: xqlfxv3q6l2u1dvotugofq/ 'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly. Remove the redundant 'flush_workqueue()' calls. This was generated with coccinelle: @@ expression E; @@ - flush_workqueue(E); destroy_workqueue(E); Signed-off-by: Chen Ni --- drivers/input/misc/cs40l50-vibra.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/misc/cs40l50-vibra.c b/drivers/input/misc/cs40l50-vibra.c index dce3b0ec8cf3..0fc7ab032cf5 100644 --- a/drivers/input/misc/cs40l50-vibra.c +++ b/drivers/input/misc/cs40l50-vibra.c @@ -480,7 +480,6 @@ static int cs40l50_erase(struct input_dev *dev, int effect_id) static void cs40l50_remove_wq(void *data) { - flush_workqueue(data); destroy_workqueue(data); }