| Message ID | 20250319191320.10092-10-lkml@antheas.dev (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | HID: asus: hid-asus and asus-wmi backlight unification, Z13 QOL improvements | expand |
On 20/03/25 08:13, Antheas Kapenekakis wrote: > The quirk for selecting whether keyboard backlight should be controlled > by HID or WMI is not needed anymore, so remove it. > > Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev> > --- > include/linux/platform_data/x86/asus-wmi.h | 40 ---------------------- > 1 file changed, 40 deletions(-) > > diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h > index 42e963b70acdb..add04524031d8 100644 > --- a/include/linux/platform_data/x86/asus-wmi.h > +++ b/include/linux/platform_data/x86/asus-wmi.h > @@ -183,44 +183,4 @@ static inline void asus_brt_unregister_listener(struct asus_brt_listener *bdev) > } > #endif > > -/* To be used by both hid-asus and asus-wmi to determine which controls kbd_brightness */ > -static const struct dmi_system_id asus_use_hid_led_dmi_ids[] = { > - { > - .matches = { > - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Zephyrus"), > - }, > - }, > - { > - .matches = { > - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Strix"), > - }, > - }, > - { > - .matches = { > - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Flow"), > - }, > - }, > - { > - .matches = { > - DMI_MATCH(DMI_PRODUCT_FAMILY, "ProArt P16"), > - }, > - }, > - { > - .matches = { > - DMI_MATCH(DMI_BOARD_NAME, "GA403U"), > - }, > - }, > - { > - .matches = { > - DMI_MATCH(DMI_BOARD_NAME, "GU605M"), > - }, > - }, > - { > - .matches = { > - DMI_MATCH(DMI_BOARD_NAME, "RC71L"), > - }, > - }, > - { }, > -}; > - > #endif /* __PLATFORM_DATA_X86_ASUS_WMI_H */ I think this can be squashed in to patch 8 as it looks likely to cause an "unused" warning or error? I'll defer to others though. Cheers, Luke.
On Thu, 20 Mar 2025 at 08:11, Luke D. Jones <luke@ljones.dev> wrote: > > On 20/03/25 08:13, Antheas Kapenekakis wrote: > > The quirk for selecting whether keyboard backlight should be controlled > > by HID or WMI is not needed anymore, so remove it. > > > > Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev> > > --- > > include/linux/platform_data/x86/asus-wmi.h | 40 ---------------------- > > 1 file changed, 40 deletions(-) > > > > diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h > > index 42e963b70acdb..add04524031d8 100644 > > --- a/include/linux/platform_data/x86/asus-wmi.h > > +++ b/include/linux/platform_data/x86/asus-wmi.h > > @@ -183,44 +183,4 @@ static inline void asus_brt_unregister_listener(struct asus_brt_listener *bdev) > > } > > #endif > > > > -/* To be used by both hid-asus and asus-wmi to determine which controls kbd_brightness */ > > -static const struct dmi_system_id asus_use_hid_led_dmi_ids[] = { > > - { > > - .matches = { > > - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Zephyrus"), > > - }, > > - }, > > - { > > - .matches = { > > - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Strix"), > > - }, > > - }, > > - { > > - .matches = { > > - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Flow"), > > - }, > > - }, > > - { > > - .matches = { > > - DMI_MATCH(DMI_PRODUCT_FAMILY, "ProArt P16"), > > - }, > > - }, > > - { > > - .matches = { > > - DMI_MATCH(DMI_BOARD_NAME, "GA403U"), > > - }, > > - }, > > - { > > - .matches = { > > - DMI_MATCH(DMI_BOARD_NAME, "GU605M"), > > - }, > > - }, > > - { > > - .matches = { > > - DMI_MATCH(DMI_BOARD_NAME, "RC71L"), > > - }, > > - }, > > - { }, > > -}; > > - > > #endif /* __PLATFORM_DATA_X86_ASUS_WMI_H */ > > I think this can be squashed in to patch 8 as it looks likely to cause > an "unused" warning or error? I'll defer to others though. I tried to avoid going cross-platform for these three patches. If someone has a better suggestion to do it I would be happy to do that instead, incl maybe adding a __maybe_unused as part of the previous patch. > Cheers, > Luke. > Antheas
diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h index 42e963b70acdb..add04524031d8 100644 --- a/include/linux/platform_data/x86/asus-wmi.h +++ b/include/linux/platform_data/x86/asus-wmi.h @@ -183,44 +183,4 @@ static inline void asus_brt_unregister_listener(struct asus_brt_listener *bdev) } #endif -/* To be used by both hid-asus and asus-wmi to determine which controls kbd_brightness */ -static const struct dmi_system_id asus_use_hid_led_dmi_ids[] = { - { - .matches = { - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Zephyrus"), - }, - }, - { - .matches = { - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Strix"), - }, - }, - { - .matches = { - DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Flow"), - }, - }, - { - .matches = { - DMI_MATCH(DMI_PRODUCT_FAMILY, "ProArt P16"), - }, - }, - { - .matches = { - DMI_MATCH(DMI_BOARD_NAME, "GA403U"), - }, - }, - { - .matches = { - DMI_MATCH(DMI_BOARD_NAME, "GU605M"), - }, - }, - { - .matches = { - DMI_MATCH(DMI_BOARD_NAME, "RC71L"), - }, - }, - { }, -}; - #endif /* __PLATFORM_DATA_X86_ASUS_WMI_H */
The quirk for selecting whether keyboard backlight should be controlled by HID or WMI is not needed anymore, so remove it. Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev> --- include/linux/platform_data/x86/asus-wmi.h | 40 ---------------------- 1 file changed, 40 deletions(-)