| Message ID | 20250322102804.418000-9-lkml@antheas.dev (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: asus: Add RGB Support to Asus Z13, Ally, unify backlight asus-wmi, and Z13 QOL | expand |
On 22/03/25 23:28, Antheas Kapenekakis wrote: > If the asus-wmi brightness handler is available, send the > keyboard brightness events to it instead of passing them > to userspace. If it is not, fall back to sending them to it. > > Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev> > --- > drivers/hid/hid-asus.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c > index c40b5c14c797f..905453a4eb5b7 100644 > --- a/drivers/hid/hid-asus.c > +++ b/drivers/hid/hid-asus.c > @@ -318,6 +318,17 @@ static int asus_event(struct hid_device *hdev, struct hid_field *field, > usage->hid & HID_USAGE); > } > > + if (usage->type == EV_KEY && value) { > + switch (usage->code) { > + case KEY_KBDILLUMUP: > + return !asus_hid_event(ASUS_EV_BRTUP); > + case KEY_KBDILLUMDOWN: > + return !asus_hid_event(ASUS_EV_BRTDOWN); > + case KEY_KBDILLUMTOGGLE: > + return !asus_hid_event(ASUS_EV_BRTTOGGLE); > + } > + } > + > return 0; > } > Possible commit squash candidate in to patch 7. I'll defer to Ilpo and Hans though. Reviewed-by: Luke D. Jones <luke@ljones.dev> Tested-by: Luke D. Jones <luke@ljones.dev>
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index c40b5c14c797f..905453a4eb5b7 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -318,6 +318,17 @@ static int asus_event(struct hid_device *hdev, struct hid_field *field, usage->hid & HID_USAGE); } + if (usage->type == EV_KEY && value) { + switch (usage->code) { + case KEY_KBDILLUMUP: + return !asus_hid_event(ASUS_EV_BRTUP); + case KEY_KBDILLUMDOWN: + return !asus_hid_event(ASUS_EV_BRTDOWN); + case KEY_KBDILLUMTOGGLE: + return !asus_hid_event(ASUS_EV_BRTTOGGLE); + } + } + return 0; }
If the asus-wmi brightness handler is available, send the keyboard brightness events to it instead of passing them to userspace. If it is not, fall back to sending them to it. Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev> --- drivers/hid/hid-asus.c | 11 +++++++++++ 1 file changed, 11 insertions(+)