From patchwork Thu Apr 10 14:28:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Heidelberg X-Patchwork-Id: 14046596 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 235112853F5; Thu, 10 Apr 2025 14:28:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744295304; cv=none; b=tEnHzGRRVaPqzIfiSfquVK7nss4+avdC4VyByb5gQqrMNyuLSRaoilYhKmbO1NdqZlCG112J6OJ0lypJf5YREWDiS+uJJFhcr/MOwm4kexLyC9KjrFYbIF1IToHwfjlqRa+R61yk1yc4DzsuDOkkhw2HCM9UCNQNIrqt9T84Uwo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744295304; c=relaxed/simple; bh=q6YqJI+AWlDUFmDegEVniY4d+tNOgVnSi2YYjBl+5n0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YyJNAGbyCo/dHXwXcRue8Ayc9n/LHt/t17Jz4IVGBmyUFPKvk2piyf1zSWOUDBNW3Q50WWf4BHgTsotOJ3hyHFs4DaIJ8J3C78tVQEbj0lVPf98AcJh1p0mBp92Y0Oy5RzTztb2x6NlumgPbTAjwjvHz7jI/h/vUjyk1lVeoW9g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ibU5IqEK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ibU5IqEK" Received: by smtp.kernel.org (Postfix) with ESMTPS id ABEA0C4CEEA; Thu, 10 Apr 2025 14:28:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744295303; bh=q6YqJI+AWlDUFmDegEVniY4d+tNOgVnSi2YYjBl+5n0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=ibU5IqEKAIvSgIaFpqQuU5Y7ZhrbMAcplYjmjWGf+6x2v/sYheuZtrnEOWdf2LZdw 8oC8Mw8srudBIfyU7Rxl1iFccjSfbe/zKdcwaFHrQiucygT2VDR6hddP0KmUfWJmnP imkpHuKUrwe/5g7KYjjiQgXvVgVanOse869c72JhOg79H2/Jmv+htI3+ZvOOiuZYij U3YQt8XtjKnr4+n+Lg8zmWF2C3c2n8eEXdC8VoTSgdJD8PNABFeGq+S4Hfle0Q+FUJ NXsN+YBNdbuVm/03oi4Jpf70e7JvwKzV8J3LDh8ih+3oyTZLLdJTjuSmVpmeo0Whsr eZS4Dlw/SU9Ew== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A112C369A5; Thu, 10 Apr 2025 14:28:23 +0000 (UTC) Date: Thu, 10 Apr 2025 16:28:20 +0200 Subject: [PATCH v5 2/7] Input: synaptics-rmi4 - handle duplicate/unknown PDT entries Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250410-synaptics-rmi4-v5-2-b41bb90f78b9@ixit.cz> References: <20250410-synaptics-rmi4-v5-0-b41bb90f78b9@ixit.cz> In-Reply-To: <20250410-synaptics-rmi4-v5-0-b41bb90f78b9@ixit.cz> To: Kaustabh Chakraborty , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Jason A. Donenfeld" , Matthias Schiffer , Vincent Huang Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Caleb Connolly , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3909; i=david@ixit.cz; h=from:subject:message-id; bh=UsHStuHcTC7EY8d7D+PJ8GiyG0tV5bXzwAzuKYQFCvE=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBn99WFm4V/QP30jEL9ZXlRModhu4BlXuozpNi3P 0KIMBHrHK6JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ/fVhQAKCRBgAj/E00kg cs/vEACRzylm4inhcAvtVjq2ISNeuZVD9clfOVdzwbjHvTygb4K/5ekmKlGPWumnybaHuMqrv/B 8q91E8HBouP9eQKy4yh1UIlV/5ovY5Qc+zRU4hnC51wRpU1GeFLyvaynjYLNwj+bgUzIoOIaYCM BhEweq7Qs03shV4gFJK3ci6Ine5e0G3qwoPAA2YKCMLu5rrPDg4QWL4yRaWAl+778eSAZprjpfl 2vJixN31FHibG0DevWRkAdincQejdRxKjQOwO8eUrzOBokTuQ/YAfceQOI0CkcPajpoEtQHq2my UPNv6xSec5sKRe3JjIQ1IigTgGYf+mwJEm+rDQGgMaWhqj/KH7KFR//eERGE7/awaqSPgIwHn0p d2zESGKmXFVuXa2vimccvhy2Gq0r/1sFTf7KA4+LG/kd0LGh2P223J4x3J7slgYpWF93+cS7IZ7 X3zZCcHhFRqc0Z8+8rdey3nVBPHk1DIAKpfG6kKT/H/NADYaYkDJP/3/nDf3AtmhRY2WA3inuT+ qbRFmIUFN5wuBYxYZryPms9UQoG7h78QFhvdw7Hzq9Pyjpn9FSFXb0hqnCvErbw9QsKGFkHPTW6 Sf5v8VxFwfbZ2/FggKP+JRcCu3M+u6kZV/y+rvhuCXHnOj2xDRQflJLoepKDf5TaG/Qr3CzoVZ/ qESDMJJgYANOUJQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg From: Caleb Connolly Some third party rmi4-compatible ICs don't expose their PDT entries very well. Add a few checks to skip duplicate entries as well as entries for unsupported functions. This is required to support some phones with third party displays. Validated on a stock OnePlus 6T (original parts): manufacturer: Synaptics, product: S3706B, fw id: 2852315 Co-developed-by: Kaustabh Chakraborty Signed-off-by: Kaustabh Chakraborty Signed-off-by: Caleb Connolly Co-developed-by: David Heidelberg Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_driver.c | 42 +++++++++++++++++++++++++++++++++++------ drivers/input/rmi4/rmi_driver.h | 8 ++++++++ 2 files changed, 44 insertions(+), 6 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index 2168b6cd7167334d44553c9c566f870a4e034179..0f6dbe586c652d641178f43ec27df3613126ca66 100644 --- a/drivers/input/rmi4/rmi_driver.c +++ b/drivers/input/rmi4/rmi_driver.c @@ -493,12 +493,39 @@ static void rmi_driver_copy_pdt_to_fd(const struct pdt_entry *pdt, fd->function_version = pdt->function_version; } +static bool rmi_pdt_entry_is_valid(struct rmi_device *rmi_dev, + struct pdt_scan_state *state, u8 fn) +{ + switch (fn) { + case 0x01: + case 0x03: + case 0x11: + case 0x12: + case 0x30: + case 0x34: + case 0x3a: + case 0x54: + case 0x55: + if (state->pdts[fn] == true) + return false; + break; + default: + rmi_dbg(RMI_DEBUG_CORE, &rmi_dev->dev, + "PDT has unknown function number %#02x\n", fn); + return false; + } + + state->pdts[fn] = true; + state->pdt_count++; + return true; +} + #define RMI_SCAN_CONTINUE 0 #define RMI_SCAN_DONE 1 static int rmi_scan_pdt_page(struct rmi_device *rmi_dev, int page, - int *empty_pages, + struct pdt_scan_state *state, void *ctx, int (*callback)(struct rmi_device *rmi_dev, void *ctx, @@ -521,6 +548,9 @@ static int rmi_scan_pdt_page(struct rmi_device *rmi_dev, if (RMI4_END_OF_PDT(pdt_entry.function_number)) break; + if (!rmi_pdt_entry_is_valid(rmi_dev, state, pdt_entry.function_number)) + continue; + retval = callback(rmi_dev, ctx, &pdt_entry); if (retval != RMI_SCAN_CONTINUE) return retval; @@ -531,11 +561,11 @@ static int rmi_scan_pdt_page(struct rmi_device *rmi_dev, * or more is found, stop scanning. */ if (addr == pdt_start) - ++*empty_pages; + ++state->empty_pages; else - *empty_pages = 0; + state->empty_pages = 0; - return (data->bootloader_mode || *empty_pages >= 2) ? + return (data->bootloader_mode || state->empty_pages >= 2) ? RMI_SCAN_DONE : RMI_SCAN_CONTINUE; } @@ -544,11 +574,11 @@ int rmi_scan_pdt(struct rmi_device *rmi_dev, void *ctx, void *ctx, const struct pdt_entry *entry)) { int page; - int empty_pages = 0; + struct pdt_scan_state state = {0, 0, {0}}; int retval = RMI_SCAN_DONE; for (page = 0; page <= RMI4_MAX_PAGE; page++) { - retval = rmi_scan_pdt_page(rmi_dev, page, &empty_pages, + retval = rmi_scan_pdt_page(rmi_dev, page, &state, ctx, callback); if (retval != RMI_SCAN_CONTINUE) break; diff --git a/drivers/input/rmi4/rmi_driver.h b/drivers/input/rmi4/rmi_driver.h index 3bfe9013043ef3dff46249095a5b3116c8f7d9a6..cb1cacd013a3f39db96935f705f18018bf15adff 100644 --- a/drivers/input/rmi4/rmi_driver.h +++ b/drivers/input/rmi4/rmi_driver.h @@ -46,6 +46,14 @@ struct pdt_entry { u8 function_number; }; +#define RMI_PDT_MAX 0x55 + +struct pdt_scan_state { + u8 empty_pages; + u8 pdt_count; + bool pdts[RMI_PDT_MAX]; +}; + #define RMI_REG_DESC_PRESENSE_BITS (32 * BITS_PER_BYTE) #define RMI_REG_DESC_SUBPACKET_BITS (37 * BITS_PER_BYTE)